Fireperf fragments: lifecycle callbacks #3565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs
Notes |
firebase-perf/src/main/java/com/google/firebase/perf/application/FragmentMonitor.java
Outdated
Show resolved
Hide resolved
Size Report 1Affected Products
Test Logs
Notes |
jeremyjiang-dev
approved these changes
Mar 18, 2022
visumickey
approved these changes
Mar 21, 2022
firebase-perf/src/main/java/com/google/firebase/perf/application/FragmentStateMonitor.java
Outdated
Show resolved
Hide resolved
|
|
||
| public FragmentStateMonitor( | ||
| FragmentActivity activity, | ||
| Clock clock, |
There was a problem hiding this comment.
Why do we need a clock instance here?
There was a problem hiding this comment.
because new Trace(...) needs a clock, for making a screen trace
firebase-perf/src/main/java/com/google/firebase/perf/application/FragmentStateMonitor.java
Outdated
Show resolved
Hide resolved
|
@leotianlizhan: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
tests failures looks unrelated, seems like it's coming from remote-config, will just merge. |
leotianlizhan
changed the title
leotianlizhan
added a commit
that referenced
this pull request
Apr 7, 2022
* Add fragment trace sampling rate config flag (#3546) * Fireperf: fragment lifecycle callbacks (#3565) * onResume and onPause * copyright * rename to * more specific language * Fireperf fragments: trace creation and adding custom attributes (#3575) * implementation * test * gjf * ebugfix * copyright * add tests * long name test * fix test * change error to warn message * Fix hasFrameMetricsAggregator's value not being set. * Fix googleJavaFormat error * Add frame metrics to fragment traces (#3592) * Add frame metrics to fragment traces. * Fix AppStateMonitor.java * Rename FrameMetrics to PerfFrameMetrics * Fix screen trace logging by printing the trace name. (#3599) * Fireperf fragments: sampling (#3588) * ssample fragment after trace already sampled * gjf * tests and qol for immutable bundle * test names and revert getFloat * fragment-sampling * fix test * separate bucketId checkArguments * Fireperf fragments eap: change version number (#3604) * change version number * changelog * changelog edit * Update the gradle properties to match the EAP release branch (#3606) * Update the gradle properties to match the release branch * Revert ktx gradle properties * default no0 sampling rate * gradle.properties revert * gradle.properties revert 2 * fix unit tests * review Co-authored-by: Visu <[email protected]> Co-authored-by: Leo Zhan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/208271814
This PR doesn't include tests to unblock the other implementation tasks, tests will be added in another PR.
EDIT: actually don't see a reason to test because these are just lifecycle callbacks, there's nothing in those callbacks so there's nothing to test.