Skip to content

Fireperf: Add Fragment Screen Performance Support #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 7, 2022
Merged

Fireperf: Add Fragment Screen Performance Support #3591

merged 16 commits into from
Apr 7, 2022

Conversation

jeremyjiang-dev
Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev commented Mar 25, 2022 •
edited by leotianlizhan
Loading

Task

b/228031168
Merging the EAP branch for fragment performance metrics to master

Changes aside from the entire EAP branch

  1. Set the default fragment sampling rate to 0%
  2. Manifest override the dev/e2e test apps sampling rate to 100%
  3. Set version code to 20.0.7 (instead of the 20.0.7-eap that was for the EAP branch)

visumickey and others added 3 commits March 17, 2022 12:19
@visumickey
Add fragment trace sampling rate config flag (#3546)
23d1a5e
@leotianlizhan
Fireperf: fragment lifecycle callbacks (#3565)
6a42873 
* onResume and onPause

* copyright

* rename to

* more specific language
@leotianlizhan
Fireperf fragments: trace creation and adding custom attributes (#3575)
2fed9e4 
* implementation

* test

* gjf

* ebugfix

* copyright

* add tests

* long name test

* fix test

* change error to warn message
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 25, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-perf

    Overall coverage changed from 70.84% (a751091) to 71.40% (facf8c7) by +0.56%.

    FilenameBase (a751091)Merge (facf8c7)Diff
    AppStateMonitor.java87.22%88.57%+1.35%
    ConfigResolver.java97.23%97.38%+0.15%
    ConfigurationConstants.java99.21%99.25%+0.04%
    FragmentStateMonitor.java?91.67%?
    FrameMetricsCalculator.java?96.30%?
    RateLimiter.java89.83%90.98%+1.15%
    ScreenTraceUtil.java?94.12%?
    TraceMetric.java43.42%43.98%+0.56%

Test Logs

Notes

  • Commit (facf8c7) is created by Prow via merging PR base commit (a751091) and head commit (488a8a4).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/A33zZgcpx9.html

jeremyjiang-dev and others added 2 commits March 25, 2022 16:30
@jeremyjiang-dev
Fix googleJavaFormat error
987db30
@jeremyjiang-dev
Add frame metrics to fragment traces (#3592)
f226e41 
* Add frame metrics to fragment traces.

* Fix AppStateMonitor.java

* Rename FrameMetrics to PerfFrameMetrics
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 28, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-perf

    TypeBase (a751091)Merge (facf8c7)Diff
    aar302 kB307 kB+5.83 kB (+1.9%)
    apk (aggressive)982 kB1.03 MB+44.1 kB (+4.5%)
    apk (release)2.46 MB2.47 MB+2.57 kB (+0.1%)

Test Logs

Notes

  • Commit (facf8c7) is created by Prow via merging PR base commit (a751091) and head commit (488a8a4).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6FyYU2Z8bN.html

jeremyjiang-dev and others added 7 commits March 29, 2022 13:22
@jeremyjiang-dev
Fix screen trace logging by printing the trace name. (#3599)
84bb05b
@leotianlizhan
Fireperf fragments: sampling (#3588)
7472e2e 
* ssample fragment after trace already sampled

* gjf

* tests and qol for immutable bundle

* test names and revert getFloat

* fragment-sampling

* fix test

* separate bucketId checkArguments
@leotianlizhan
Fireperf fragments eap: change version number (#3604)
7469744 
* change version number

* changelog

* changelog edit
@jeremyjiang-dev
Update the gradle properties to match the EAP release branch (#3606)
5e5ca9f 
* Update the gradle properties to match the release branch

* Revert ktx gradle properties
@leotianlizhan
default no0 sampling rate
b627204
@leotianlizhan
gradle.properties revert
93b4b91
@leotianlizhan
gradle.properties revert 2
5b846b9
@leotianlizhan leotianlizhan requested a review from visumickey April 5, 2022 17:20
@leotianlizhan
Copy link
Contributor

/retest

@jeremyjiang-dev
Copy link
Contributor Author

LGTM! I am the author so that I cannot LGTM this PR.
@leotianlizhan Feel free to merge the PR once you get all the LGTM

@visumickey
Copy link
Contributor

DO_NOT_SUBMIT

Can we please edit the description of the PR with the following?

  1. What are we doing with this PR? (Merging the EAP branch for fragment performance metrics to master)
  2. Mention the changes that are going in on top of the changes in the EAP branch
  3. "Remove" the DO_NOT_SUBMIT tag since that means that this PR is still in draft state.

visumickey
visumickey reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to this, can we also make the change to the E2E test apps and the Dev test app to have manifest overrides to set the fragment sampling rate to 100% to make sure we have those apps send the fragment events for processing?

@leotianlizhan leotianlizhan requested a review from visumickey April 7, 2022 21:19
@leotianlizhan leotianlizhan merged commit 26c905b into master Apr 7, 2022
@leotianlizhan leotianlizhan deleted the perfFragmentsEAP branch April 7, 2022 23:46
@firebase firebase locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremyjiang-dev @google-oss-bot @leotianlizhan @visumickey