Skip to content

Fix refresh logic for App Check custom providers. #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 23, 2022
Merged

Fix refresh logic for App Check custom providers. #3582

merged 3 commits into from
Mar 23, 2022

Conversation

rosalyntan
Copy link
Member

Fixes #3561.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 23, 2022 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (cf374de) and merge commit (b876a3c).

Test Logs

Notes

  • Commit (b876a3c) is created by Prow via merging PR base commit (cf374de) and head commit (be56847).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7zT3FscuYH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 23, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appcheck

    TypeBase (cf374de)Merge (b876a3c)Diff
    aar37.1 kB37.2 kB+44 B (+0.1%)
    apk (aggressive)330 kB330 kB+8 B (+0.0%)

Test Logs

Notes

  • Commit (b876a3c) is created by Prow via merging PR base commit (cf374de) and head commit (be56847).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gaRDKGy6xy.html

@rosalyntan rosalyntan marked this pull request as ready for review March 23, 2022 19:39
@rosalyntan rosalyntan requested a review from malcolmdeck March 23, 2022 19:48
malcolmdeck
malcolmdeck approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@malcolmdeck malcolmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one nit.

@rosalyntan rosalyntan merged commit b5d1df8 into master Mar 23, 2022
@rosalyntan rosalyntan deleted the rosalyntan.custom branch March 23, 2022 20:42
jeremyjiang-dev pushed a commit that referenced this pull request Mar 24, 2022
@rosalyntan @jeremyjiang-dev
Fix refresh logic for App Check custom providers. (#3582)
272e9c8 
* Fix refresh logic for App Check custom providers.

* Update tests.

* Extract 1000L into a constant.
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@rosalyntan @jeremyjiang-dev
Fix refresh logic for App Check custom providers. (#3582)
85a9907 
* Fix refresh logic for App Check custom providers.

* Update tests.

* Extract 1000L into a constant.
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@rosalyntan @jeremyjiang-dev
Fix refresh logic for App Check custom providers. (#3582)
c923524 
* Fix refresh logic for App Check custom providers.

* Update tests.

* Extract 1000L into a constant.
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@rosalyntan @jeremyjiang-dev
Fix refresh logic for App Check custom providers. (#3582)
2999ae7 
* Fix refresh logic for App Check custom providers.

* Update tests.

* Extract 1000L into a constant.
@firebase firebase locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@malcolmdeck malcolmdeck malcolmdeck approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppCheck Custom Token refreshed in infinite loop
3 participants
@rosalyntan @google-oss-bot @malcolmdeck