Skip to content

Skip custom attributes when the length of the key or the value is 0 #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 20, 2022
Merged

Skip custom attributes when the length of the key or the value is 0 #3660

merged 13 commits into from
Apr 20, 2022

Conversation

visumickey
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 18, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-perf

    Overall coverage changed from 71.48% (20da1e7) to 71.35% (fb4d895) by -0.13%.

    FilenameBase (20da1e7)Merge (fb4d895)Diff
    FirebasePerformance.java79.57%79.12%-0.45%
    FirebasePerfTraceValidator.java89.01%85.87%-3.14%
    HttpMetric.java91.78%92.65%+0.87%
    PerfMetricValidator.java90.32%93.55%+3.23%
    RateLimiter.java91.73%90.98%-0.75%
    Trace.java96.69%96.67%-0.03%
    TraceMetric.java43.98%43.14%-0.84%
    TransportManager.java95.81%94.88%-0.93%

Test Logs

Notes

  • Commit (fb4d895) is created by Prow via merging PR base commit (20da1e7) and head commit (ed794ec).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xMrDS70mGO.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 18, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-perf

    TypeBase (20da1e7)Merge (fb4d895)Diff
    aar308 kB308 kB-411 B (-0.1%)
    apk (aggressive)1.03 MB1.03 MB+16 B (+0.0%)
    apk (release)2.47 MB2.47 MB+76 B (+0.0%)

Test Logs

Notes

  • Commit (fb4d895) is created by Prow via merging PR base commit (20da1e7) and head commit (ed794ec).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VkoEmA32Hl.html

jeremyjiang-dev
jeremyjiang-dev reviewed Apr 18, 2022
View reviewed changes
jeremyjiang-dev
jeremyjiang-dev reviewed Apr 18, 2022
View reviewed changes
raymondlam
raymondlam reviewed Apr 19, 2022
View reviewed changes
raymondlam
raymondlam approved these changes Apr 19, 2022
View reviewed changes
jposuna
jposuna approved these changes Apr 19, 2022
View reviewed changes
@visumickey
Copy link
Contributor Author

/retest

leotianlizhan
leotianlizhan approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@leotianlizhan leotianlizhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to make errors thrown from the origin so we have better stacktraces for debugging!

@visumickey visumickey merged commit bd7b2df into master Apr 20, 2022
@visumickey visumickey deleted the perfCustomAttributeCheck branch April 20, 2022 18:39
@firebase firebase locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jposuna jposuna jposuna approved these changes

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

@raymondlam raymondlam raymondlam approved these changes

@leotianlizhan leotianlizhan leotianlizhan approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@visumickey @google-oss-bot @jposuna @raymondlam @leotianlizhan @jeremyjiang-dev