-
Notifications
You must be signed in to change notification settings - Fork 627
Fix dynamic module support bug https://github.com/firebase/firebase-android-sdk/issues/3860 #3870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report 1Affected ProductsNo changes between base commit (f3f2f4c) and merge commit (018f68e).Test Logs
Notes |
Size Report 1Affected Products
Test Logs
Notes |
firebase-components/firebase-dynamic-module-support/firebase-dynamic-module-support.gradle
Outdated
Show resolved
Hide resolved
Reference the issue in the description instead of the title so it can be tracked by github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sync your branch to current master(specifically till after #3871), so that tests actually run for this PR?
@@ -45,5 +45,6 @@ android { | |||
dependencies { | |||
implementation project(':firebase-common') | |||
implementation project(':firebase-components') | |||
implementation 'com.google.android.play:core:1.9.0' | |||
implementation 'com.google.android.play:feature-delivery:2.0.0' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm empty line
Move from monolithic to partitioned apis at https://developer.android.com/reference/com/google/android/play/core/release-notes#partitioned-apis
Fixes #3860