Skip to content

Fix dynamic module support bug https://github.com/firebase/firebase-android-sdk/issues/3860 #3870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 6, 2022

Conversation

VinayGuthal
Copy link
Contributor

@VinayGuthal VinayGuthal commented Jul 5, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Unit Test Results

0 files   -    392  0 suites   - 392   0s ⏱️ - 17m 22s
0 tests  - 4 700  0 ✔️  - 4 676  0 💤  - 22  0  - 2 
0 runs   - 4 716  0 ✔️  - 4 692  0 💤  - 22  0  - 2 

Results for commit 450f198. ± Comparison against base commit 3c323f2.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 5, 2022

Coverage Report 1

Affected Products

No changes between base commit (f3f2f4c) and merge commit (018f68e).

Test Logs

Notes

  • Commit (018f68e) is created by Prow via merging PR base commit (f3f2f4c) and head commit (450f198).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5yVA6SL2Xa.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 5, 2022

Size Report 1

Affected Products

  • firebase-dynamic-module-support

    TypeBase (f3f2f4c)Merge (018f68e)Diff
    aar5.85 kB5.88 kB+22 B (+0.4%)
    apk (aggressive)145 kB94.1 kB-50.9 kB (-35.1%)
    apk (release)802 kB742 kB-59.7 kB (-7.4%)

Test Logs

Notes

  • Commit (018f68e) is created by Prow via merging PR base commit (f3f2f4c) and head commit (450f198).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Sv9DwxGRh6.html

@rlazo
Copy link
Collaborator

rlazo commented Jul 5, 2022

Reference the issue in the description instead of the title so it can be tracked by github.

@VinayGuthal VinayGuthal requested review from vkryachko and rlazo July 6, 2022 16:16
Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sync your branch to current master(specifically till after #3871), so that tests actually run for this PR?

@@ -45,5 +45,6 @@ android {
dependencies {
implementation project(':firebase-common')
implementation project(':firebase-components')
implementation 'com.google.android.play:core:1.9.0'
implementation 'com.google.android.play:feature-delivery:2.0.0'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm empty line

@VinayGuthal VinayGuthal merged commit 1b5e956 into master Jul 6, 2022
@VinayGuthal VinayGuthal deleted the fix_dynamic_module_support_bug branch July 6, 2022 17:36
@firebase firebase locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase-dynamic-module-support's monolithic play-core lib dependency causes duplicate classes
4 participants