Skip to content

Fix reports endpoint URL #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix reports endpoint URL #3899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionTesterApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ Task<String> createFeedback(String testerReleaseName, String feedbackText) {
return runWithFidAndToken(
(unused, token) -> {
LogWrapper.getInstance().i("Creating feedback for release: " + testerReleaseName);
String path = String.format("v1alpha/%s/feedback", testerReleaseName);
String path = String.format("v1alpha/%s/feedbackReports", testerReleaseName);
String requestBody = buildCreateFeedbackBody(feedbackText).toString();
JSONObject responseBody =
testerApiHttpClient.makePostRequest(CREATE_FEEDBACK_TAG, path, token, requestBody);
Expand Down
8 changes: 4 additions & 4 deletions .../com/google/firebase/appdistribution/impl/FirebaseAppDistributionTesterApiClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public class FirebaseAppDistributionTesterApiClientTest {
private static final String RELEASE_NAME =
"projects/123456789/installations/cccccccccccccccccccccc/releases/release-id";
private static final String FEEDBACK_NAME =
"projects/123456789/installations/cccccccccccccccccccccc/releases/release-id/feedback/feedback-id";
"projects/123456789/installations/cccccccccccccccccccccc/releases/release-id/feedbackReports/feedback-id";
private static final String FEEDBACK_TEXT = "The feedback";
private static final String APK_HASH = "apk-hash";
private static final String IAS_ARTIFACT_ID = "ias-artifact-id";
Expand All @@ -67,11 +67,11 @@ public class FirebaseAppDistributionTesterApiClientTest {
private static final String FIND_RELEASE_USING_IAS_PATH =
"v1alpha/projects/123456789/installations/cccccccccccccccccccccc/releases:find?iasArtifactId=ias-artifact-id";
private static final String CREATE_FEEDBACK_PATH =
"v1alpha/projects/123456789/installations/cccccccccccccccccccccc/releases/release-id/feedback";
"v1alpha/projects/123456789/installations/cccccccccccccccccccccc/releases/release-id/feedbackReports";
private static final String COMMIT_FEEDBACK_PATH =
"v1alpha/projects/123456789/installations/cccccccccccccccccccccc/releases/release-id/feedback/feedback-id:commit";
"v1alpha/projects/123456789/installations/cccccccccccccccccccccc/releases/release-id/feedbackReports/feedback-id:commit";
private static final String ATTACH_SCREENSHOT_PATH =
"upload/v1alpha/projects/123456789/installations/cccccccccccccccccccccc/releases/release-id/feedback/feedback-id:uploadArtifact?type=SCREENSHOT";
"upload/v1alpha/projects/123456789/installations/cccccccccccccccccccccc/releases/release-id/feedbackReports/feedback-id:uploadArtifact?type=SCREENSHOT";

private FirebaseAppDistributionTesterApiClient firebaseAppDistributionTesterApiClient;
@Mock private Provider<FirebaseInstallationsApi> mockFirebaseInstallationsProvider;
Expand Down