Skip to content

Fix reports endpoint URL #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix reports endpoint URL #3899

merged 1 commit into from
Jul 14, 2022

Conversation

lfkellogg
Copy link
Contributor

No description provided.

@lfkellogg lfkellogg requested review from jladieu and kaibolay July 14, 2022 17:18
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022 •
edited
Loading

Unit Test Results

139 tests  ±0   139 ✔️ +1   45s ⏱️ +4s
  15 suites ±0       0 💤 ±0 
  15 files   ±0       0 ❌  - 1 

Results for commit 15d7d5b. ± Comparison against base commit 1e0b7f7.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 14, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (1e0b7f7) to 77.17% (6f70507) by ?.

    36 individual files with coverage change

    FilenameBase (1e0b7f7)Merge (6f70507)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?30.00%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?0.00%?
    FeedbackSender.java?90.91%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?92.79%?
    FirebaseAppDistributionLifecycleNotifier.java?75.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?81.08%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?95.45%?
    InstallActivity.java?2.53%?
    LogWrapper.java?53.33%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?65.63%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?57.14%?
    TaskUtils.java?96.30%?
    TesterApiHttpClient.java?88.35%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

Notes

  • Commit (6f70507) is created by Prow via merging PR base commit (1e0b7f7) and head commit (15d7d5b).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LggNDpfmKw.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 14, 2022 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (1e0b7f7)Merge (6f70507)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-annotations

    TypeBase (1e0b7f7)Merge (6f70507)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.88 kB? (?)

  • firebase-appdistribution

    TypeBase (1e0b7f7)Merge (6f70507)Diff
    aar?152 kB? (?)
    apk (aggressive)?879 kB? (?)
    apk (release)?2.01 MB? (?)

  • firebase-appdistribution-api

    TypeBase (1e0b7f7)Merge (6f70507)Diff
    aar?14.5 kB? (?)
    apk (aggressive)?85.5 kB? (?)
    apk (release)?697 kB? (?)

  • firebase-common

    TypeBase (1e0b7f7)Merge (6f70507)Diff
    aar?48.6 kB? (?)
    apk (aggressive)?84.8 kB? (?)
    apk (release)?690 kB? (?)

  • firebase-components

    TypeBase (1e0b7f7)Merge (6f70507)Diff
    aar?41.4 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?29.5 kB? (?)

  • firebase-installations

    TypeBase (1e0b7f7)Merge (6f70507)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?86.4 kB? (?)
    apk (release)?712 kB? (?)

  • firebase-installations-interop

    TypeBase (1e0b7f7)Merge (6f70507)Diff
    aar?8.34 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

Notes

  • Commit (6f70507) is created by Prow via merging PR base commit (1e0b7f7) and head commit (15d7d5b).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GwP7jD8ix0.html

@lfkellogg lfkellogg force-pushed the lk/fix-reports-endpoint branch from 822880b to 15d7d5b Compare July 14, 2022 21:26
@lfkellogg lfkellogg merged commit 4a82798 into master Jul 14, 2022
@lfkellogg lfkellogg deleted the lk/fix-reports-endpoint branch July 14, 2022 21:50
thatfiredev pushed a commit to thatfiredev/firebase-android-sdk that referenced this pull request Jul 15, 2022
@lfkellogg @thatfiredev
Fix reports endpoint URL (firebase#3899)
61f1717
lfkellogg added a commit that referenced this pull request Jul 19, 2022
@lfkellogg
Revert "Fix reports endpoint URL (#3899)"
7aac366 
This reverts commit 4a82798.
rlazo added a commit that referenced this pull request Jul 21, 2022
@thatfiredev @ehsannas
@rlazo @lfkellogg @wu-hui
feat: implement Firebase App Check KTX (#3893)
7c277af 
* feat: implement Firebase App Check KTX

* File must end with a newline (\n)

* Use unmodifiableList for CompositeFilters. (#3881)

* Use ImmutableList (rather than List) for CompositeFilters.

* use unmodifiableList.

* Update the query protos. (#3880)

* Clean up FirebaseApp instances before setting up a new one. (#3903)

This should fix errors seen in CI.

* Fix reports endpoint URL (#3899)

* Update name of file in CPP repo. (#3901)

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

* Ensure Client exists (#3900)

* Fix 238932261

* Change log

Co-authored-by: Ehsan <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Lee Kellogg <[email protected]>
Co-authored-by: wu-hui <[email protected]>
lfkellogg added a commit that referenced this pull request Aug 5, 2022
@thatfiredev @ehsannas
@rlazo @lfkellogg @wu-hui
feat: implement Firebase App Check KTX (#3893)
901db3b 
* feat: implement Firebase App Check KTX

* File must end with a newline (\n)

* Use unmodifiableList for CompositeFilters. (#3881)

* Use ImmutableList (rather than List) for CompositeFilters.

* use unmodifiableList.

* Update the query protos. (#3880)

* Clean up FirebaseApp instances before setting up a new one. (#3903)

This should fix errors seen in CI.

* Fix reports endpoint URL (#3899)

* Update name of file in CPP repo. (#3901)

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

* Ensure Client exists (#3900)

* Fix 238932261

* Change log

Co-authored-by: Ehsan <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Lee Kellogg <[email protected]>
Co-authored-by: wu-hui <[email protected]>
@firebase firebase locked and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jladieu jladieu jladieu approved these changes

@kaibolay kaibolay kaibolay approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfkellogg @google-oss-bot @jladieu @kaibolay