Skip to content

Ensure Client exists #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2022
Merged

Ensure Client exists #3900

merged 2 commits into from
Jul 15, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jul 14, 2022

Fixes b/Fix 238932261

@wu-hui wu-hui requested a review from cherylEnkidu July 14, 2022 19:16
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 14, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.92% (f5ac43c) to 45.88% (604887e) by -0.04%.

    FilenameBase (f5ac43c)Merge (604887e)Diff
    FirebaseFirestore.java36.87%36.67%-0.20%
    GrpcCallProvider.java62.35%51.76%-10.59%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

Notes

  • Commit (604887e) is created by Prow via merging PR base commit (f5ac43c) and head commit (2289327).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Be8Aj6Z1Fq.html

cherylEnkidu
cherylEnkidu approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@cherylEnkidu cherylEnkidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your fix!

@cherylEnkidu cherylEnkidu assigned wu-hui and unassigned cherylEnkidu Jul 14, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 090 tests  ±0   1 074 ✔️ ±0   58s ⏱️ +4s
     78 suites ±0        16 💤 ±0 
     78 files   ±0          0 ❌ ±0 

Results for commit 2289327. ± Comparison against base commit f5ac43c.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 14, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (f5ac43c)Merge (604887e)Diff
    aar1.26 MB1.26 MB-9 B (-0.0%)
    apk (release)3.39 MB3.39 MB+112 B (+0.0%)

Test Logs

Notes

  • Commit (604887e) is created by Prow via merging PR base commit (f5ac43c) and head commit (2289327).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/58tMiBvmFH.html

@wu-hui wu-hui merged commit bc62843 into master Jul 15, 2022
@wu-hui wu-hui deleted the wuandy/Fix238932261 branch July 15, 2022 01:02
thatfiredev pushed a commit to thatfiredev/firebase-android-sdk that referenced this pull request Jul 15, 2022
@wu-hui @thatfiredev
Ensure Client exists (firebase#3900)
bafc000 
* Fix 238932261

* Change log
rlazo added a commit that referenced this pull request Jul 21, 2022
@thatfiredev @ehsannas
@rlazo @lfkellogg @wu-hui
feat: implement Firebase App Check KTX (#3893)
7c277af 
* feat: implement Firebase App Check KTX

* File must end with a newline (\n)

* Use unmodifiableList for CompositeFilters. (#3881)

* Use ImmutableList (rather than List) for CompositeFilters.

* use unmodifiableList.

* Update the query protos. (#3880)

* Clean up FirebaseApp instances before setting up a new one. (#3903)

This should fix errors seen in CI.

* Fix reports endpoint URL (#3899)

* Update name of file in CPP repo. (#3901)

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

* Ensure Client exists (#3900)

* Fix 238932261

* Change log

Co-authored-by: Ehsan <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Lee Kellogg <[email protected]>
Co-authored-by: wu-hui <[email protected]>
lfkellogg added a commit that referenced this pull request Aug 5, 2022
@thatfiredev @ehsannas
@rlazo @lfkellogg @wu-hui
feat: implement Firebase App Check KTX (#3893)
901db3b 
* feat: implement Firebase App Check KTX

* File must end with a newline (\n)

* Use unmodifiableList for CompositeFilters. (#3881)

* Use ImmutableList (rather than List) for CompositeFilters.

* use unmodifiableList.

* Update the query protos. (#3880)

* Clean up FirebaseApp instances before setting up a new one. (#3903)

This should fix errors seen in CI.

* Fix reports endpoint URL (#3899)

* Update name of file in CPP repo. (#3901)

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

* Ensure Client exists (#3900)

* Fix 238932261

* Change log

Co-authored-by: Ehsan <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Lee Kellogg <[email protected]>
Co-authored-by: wu-hui <[email protected]>
@firebase firebase locked and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

@wu-hui wu-hui

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @cherylEnkidu