Fix CI issuses with AppDistro #3903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix errors seen in CI.
Coverage Report 1Affected Products
Test Logs
Notes |
lfkellogg
approved these changes
Jul 14, 2022
Size Report 1Affected ProductsNo changes between base commit (f5ac43c) and merge commit (3297aa3).Test Logs
Notes |
thatfiredev
pushed a commit
to thatfiredev/firebase-android-sdk
that referenced
this pull request
Jul 15, 2022
…#3903) This should fix errors seen in CI.
rlazo
added a commit
that referenced
this pull request
Jul 21, 2022
* feat: implement Firebase App Check KTX * File must end with a newline (\n) * Use unmodifiableList for CompositeFilters. (#3881) * Use ImmutableList (rather than List) for CompositeFilters. * use unmodifiableList. * Update the query protos. (#3880) * Clean up FirebaseApp instances before setting up a new one. (#3903) This should fix errors seen in CI. * Fix reports endpoint URL (#3899) * Update name of file in CPP repo. (#3901) To match the change done in the IOS repo firebase/firebase-ios-sdk#10009 * Ensure Client exists (#3900) * Fix 238932261 * Change log Co-authored-by: Ehsan <[email protected]> Co-authored-by: Rodrigo Lazo <[email protected]> Co-authored-by: Lee Kellogg <[email protected]> Co-authored-by: wu-hui <[email protected]>
lfkellogg
added a commit
that referenced
this pull request
Aug 5, 2022
* feat: implement Firebase App Check KTX * File must end with a newline (\n) * Use unmodifiableList for CompositeFilters. (#3881) * Use ImmutableList (rather than List) for CompositeFilters. * use unmodifiableList. * Update the query protos. (#3880) * Clean up FirebaseApp instances before setting up a new one. (#3903) This should fix errors seen in CI. * Fix reports endpoint URL (#3899) * Update name of file in CPP repo. (#3901) To match the change done in the IOS repo firebase/firebase-ios-sdk#10009 * Ensure Client exists (#3900) * Fix 238932261 * Change log Co-authored-by: Ehsan <[email protected]> Co-authored-by: Rodrigo Lazo <[email protected]> Co-authored-by: Lee Kellogg <[email protected]> Co-authored-by: wu-hui <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
ScreenshotTakerTest.takeAndDeleteScreenshot_successis consistently failing withFirebaseApp already initializederror.