Skip to content

Update the query protos. #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Update the query protos. #3880

merged 1 commit into from
Jul 13, 2022

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Jul 8, 2022

This is to reflect the latest proto updates (now in the preview branch)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Unit Test Results

1 090 tests   - 114   1 074 ✔️  - 130   53s ⏱️ - 1m 17s
     78 suites +  17        16 💤 +  16 
     78 files   +  17          0 ±    0 

Results for commit 91a3827. ± Comparison against base commit 939f90e.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.84% (939f90e) to 45.86% (802bb51) by +0.01%.

    FilenameBase (939f90e)Merge (802bb51)Diff
    AsyncQueue.java77.11%78.11%+1.00%
    DeleteMutation.java90.48%95.24%+4.76%
    StructuredQuery.java32.52%32.54%+0.03%

Test Logs

Notes

  • Commit (802bb51) is created by Prow via merging PR base commit (939f90e) and head commit (91a3827).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QOzV3bkkYr.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (939f90e)Merge (802bb51)Diff
    aar1.26 MB1.26 MB+69 B (+0.0%)
    apk (aggressive)489 kB489 kB+12 B (+0.0%)
    apk (release)3.39 MB3.39 MB-44 B (-0.0%)

Test Logs

Notes

  • Commit (802bb51) is created by Prow via merging PR base commit (939f90e) and head commit (91a3827).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FRAgCchygd.html

@ehsannas ehsannas self-assigned this Jul 8, 2022
@ehsannas
Copy link
Contributor Author

ehsannas commented Jul 8, 2022

/retest

@ehsannas ehsannas requested a review from wu-hui July 11, 2022 14:43
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Jul 11, 2022
@wu-hui wu-hui merged commit f5ac43c into master Jul 13, 2022
@wu-hui wu-hui deleted the ehsann/or-query-update-protos branch July 13, 2022 15:07
thatfiredev pushed a commit to thatfiredev/firebase-android-sdk that referenced this pull request Jul 15, 2022
rlazo added a commit that referenced this pull request Jul 21, 2022
* feat: implement Firebase App Check KTX

* File must end with a newline (\n)

* Use unmodifiableList for CompositeFilters. (#3881)

* Use ImmutableList (rather than List) for CompositeFilters.

* use unmodifiableList.

* Update the query protos. (#3880)

* Clean up FirebaseApp instances before setting up a new one. (#3903)

This should fix errors seen in CI.

* Fix reports endpoint URL (#3899)

* Update name of file in CPP repo. (#3901)

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

* Ensure Client exists (#3900)

* Fix 238932261

* Change log

Co-authored-by: Ehsan <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Lee Kellogg <[email protected]>
Co-authored-by: wu-hui <[email protected]>
lfkellogg added a commit that referenced this pull request Aug 5, 2022
* feat: implement Firebase App Check KTX

* File must end with a newline (\n)

* Use unmodifiableList for CompositeFilters. (#3881)

* Use ImmutableList (rather than List) for CompositeFilters.

* use unmodifiableList.

* Update the query protos. (#3880)

* Clean up FirebaseApp instances before setting up a new one. (#3903)

This should fix errors seen in CI.

* Fix reports endpoint URL (#3899)

* Update name of file in CPP repo. (#3901)

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

* Ensure Client exists (#3900)

* Fix 238932261

* Change log

Co-authored-by: Ehsan <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Lee Kellogg <[email protected]>
Co-authored-by: wu-hui <[email protected]>
@firebase firebase locked and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants