Skip to content

feat: implement Firebase App Check KTX #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 21, 2022
Merged

feat: implement Firebase App Check KTX #3893

merged 9 commits into from
Jul 21, 2022

Conversation

thatfiredev
Copy link
Member

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appcheck-ktx

    TypeBase (bc62843)Merge (d81798f)Diff
    aar?5.59 kB? (?)
    apk (aggressive)?350 kB? (?)
    apk (release)?1.47 MB? (?)

Test Logs

Notes

  • Commit (d81798f) is created by Prow via merging PR base commit (bc62843) and head commit (bafc000).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CQbhhiAzj4.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.17% (bc62843) to 50.18% (594c0ee) by +0.01%.

    FilenameBase (bc62843)Merge (594c0ee)Diff
    ViewProcessor.java91.79%92.10%+0.30%

  • firebase-firestore

    Overall coverage changed from 45.91% (bc62843) to 45.85% (594c0ee) by -0.07%.

    FilenameBase (bc62843)Merge (594c0ee)Diff
    FirestoreClient.java33.09%30.88%-2.21%
    IndexBackfiller.java89.06%79.69%-9.38%
    LruGarbageCollector.java90.65%84.11%-6.54%

  • firebase-messaging

    Overall coverage changed from 84.64% (bc62843) to 84.72% (594c0ee) by +0.08%.

    FilenameBase (bc62843)Merge (594c0ee)Diff
    FirebaseMessaging.java74.89%74.45%-0.44%
    MessagingAnalytics.java82.19%81.38%-0.81%
    Metadata.java57.14%61.90%+4.76%
    RequestDeduplicator.java80.00%90.00%+10.00%

  • firebase-perf

    Overall coverage changed from 71.38% (bc62843) to 71.40% (594c0ee) by +0.02%.

    FilenameBase (bc62843)Merge (594c0ee)Diff
    RateLimiter.java90.98%91.73%+0.75%

Test Logs

Notes

  • Commit (594c0ee) is created by Prow via merging PR base commit (bc62843) and head commit (2c419da).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MPoidKtmpo.html

@thatfiredev
Copy link
Member Author

/test check-changed

@thatfiredev
Copy link
Member Author

thatfiredev commented Jul 13, 2022 •
edited
Loading

Edit: a fix was sent to the main branch. I merged the changes and check-changed is passing now.

The failing unit test in check-changed seems to be in appdistribution (and maybe unrelated to this PR)?

@rlazo rlazo merged commit 7c277af into firebase:master Jul 21, 2022
lfkellogg added a commit that referenced this pull request Aug 5, 2022
@thatfiredev @ehsannas
@rlazo @lfkellogg @wu-hui
feat: implement Firebase App Check KTX (#3893)
901db3b 
* feat: implement Firebase App Check KTX

* File must end with a newline (\n)

* Use unmodifiableList for CompositeFilters. (#3881)

* Use ImmutableList (rather than List) for CompositeFilters.

* use unmodifiableList.

* Update the query protos. (#3880)

* Clean up FirebaseApp instances before setting up a new one. (#3903)

This should fix errors seen in CI.

* Fix reports endpoint URL (#3899)

* Update name of file in CPP repo. (#3901)

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

* Ensure Client exists (#3900)

* Fix 238932261

* Change log

Co-authored-by: Ehsan <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Lee Kellogg <[email protected]>
Co-authored-by: wu-hui <[email protected]>
@firebase firebase locked and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thatfiredev @google-oss-bot @rlazo @ehsannas @lfkellogg @wu-hui