Skip to content

Update name of file in CPP repo. #3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Update name of file in CPP repo. #3901

merged 2 commits into from
Jul 14, 2022

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jul 14, 2022

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009
@rlazo rlazo marked this pull request as ready for review July 14, 2022 19:36
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

Unit Test Results

   392 files  +   377     392 suites  +377   16m 36s ⏱️ + 15m 55s
4 701 tests +4 562  4 677 ✔️ +4 539  22 💤 +22  2 +1 
4 717 runs  +4 578  4 693 ✔️ +4 555  22 💤 +22  2 +1 

For more details on these failures, see this check.

Results for commit 819b406. ± Comparison against base commit 1e0b7f7.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 14, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.17% (1e0b7f7) to 50.18% (99e6572) by +0.01%.

    FilenameBase (1e0b7f7)Merge (99e6572)Diff
    BooleanNode.java92.31%100.00%+7.69%
  • firebase-firestore

    Overall coverage changed from 45.86% (1e0b7f7) to 45.86% (99e6572) by +0.00%.

    FilenameBase (1e0b7f7)Merge (99e6572)Diff
    AbstractStream.java34.81%37.02%+2.21%
    AsyncQueue.java78.11%77.11%-1.00%
    SetMutation.java97.22%94.44%-2.78%
  • firebase-messaging

    Overall coverage changed from 84.83% (1e0b7f7) to 84.95% (99e6572) by +0.12%.

    FilenameBase (1e0b7f7)Merge (99e6572)Diff
    Metadata.java57.14%61.90%+4.76%
  • firebase-perf

    Overall coverage changed from 71.35% (1e0b7f7) to 71.38% (99e6572) by +0.03%.

    FilenameBase (1e0b7f7)Merge (99e6572)Diff
    TransportManager.java93.95%94.88%+0.93%
  • firebase-storage

    Overall coverage changed from 85.85% (1e0b7f7) to 85.81% (99e6572) by -0.04%.

    FilenameBase (1e0b7f7)Merge (99e6572)Diff
    UploadTask.java80.58%80.22%-0.36%

Test Logs

Notes

  • Commit (99e6572) is created by Prow via merging PR base commit (1e0b7f7) and head commit (819b406).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0RUCS0tUmM.html

@rlazo
Copy link
Collaborator Author

rlazo commented Jul 14, 2022

/test check-changed

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 14, 2022

@rlazo
Copy link
Collaborator Author

rlazo commented Jul 14, 2022

/test check-changed

1 similar comment
@rlazo
Copy link
Collaborator Author

rlazo commented Jul 14, 2022

/test check-changed

@rlazo
Copy link
Collaborator Author

rlazo commented Jul 14, 2022

/test check-changed

@rlazo rlazo requested review from davidmotson and removed request for vkryachko July 14, 2022 22:13
@rlazo rlazo merged commit 9fc68dc into master Jul 14, 2022
@rlazo rlazo deleted the rl.cpp_change_20220714 branch July 14, 2022 22:23
thatfiredev pushed a commit to thatfiredev/firebase-android-sdk that referenced this pull request Jul 15, 2022
rlazo added a commit that referenced this pull request Jul 21, 2022
* feat: implement Firebase App Check KTX

* File must end with a newline (\n)

* Use unmodifiableList for CompositeFilters. (#3881)

* Use ImmutableList (rather than List) for CompositeFilters.

* use unmodifiableList.

* Update the query protos. (#3880)

* Clean up FirebaseApp instances before setting up a new one. (#3903)

This should fix errors seen in CI.

* Fix reports endpoint URL (#3899)

* Update name of file in CPP repo. (#3901)

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

* Ensure Client exists (#3900)

* Fix 238932261

* Change log

Co-authored-by: Ehsan <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Lee Kellogg <[email protected]>
Co-authored-by: wu-hui <[email protected]>
lfkellogg added a commit that referenced this pull request Aug 5, 2022
* feat: implement Firebase App Check KTX

* File must end with a newline (\n)

* Use unmodifiableList for CompositeFilters. (#3881)

* Use ImmutableList (rather than List) for CompositeFilters.

* use unmodifiableList.

* Update the query protos. (#3880)

* Clean up FirebaseApp instances before setting up a new one. (#3903)

This should fix errors seen in CI.

* Fix reports endpoint URL (#3899)

* Update name of file in CPP repo. (#3901)

To match the change done in the IOS repo

firebase/firebase-ios-sdk#10009

* Ensure Client exists (#3900)

* Fix 238932261

* Change log

Co-authored-by: Ehsan <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Lee Kellogg <[email protected]>
Co-authored-by: wu-hui <[email protected]>
@firebase firebase locked and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants