Remove In-App Feedback functionality from firebase-appdistribution

[lfkellogg]

This gets the new feature off of the master branch so we can continue development in a new feature branch while allowing us to ship changes to the released SDK.

[github-actions]

Unit Test Results

135 tests   - 9   135 ✔️  - 9   44s ⏱️ +14s
  14 suites  - 2       0 💤 ±0 
  14 files    - 2       0 ❌ ±0 

Results for commit 68ff11e. ± Comparison against base commit 5991287.

This pull request removes 15 and adds 6 tests. Note that renamed tests count towards both.

com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_attachScreenshotFails_failsTask
com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_commitFeedbackFails_failsTask
com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_createFeedbackFails_failsTask
com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_success
com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_withoutScreenshot_success
com.google.firebase.appdistribution.impl.FirebaseAppDistributionServiceImplTest ‑ collectAndSendFeedback_signsInTesterAndStartsActivity
com.google.firebase.appdistribution.impl.ImageUtilsTest ‑ readScaledImage_doesntExist_throws
com.google.firebase.appdistribution.impl.ImageUtilsTest ‑ readScaledImage_targetExactlyPowerOfTwoSmaller_scalesDown
com.google.firebase.appdistribution.impl.ImageUtilsTest ‑ readScaledImage_targetHeightIsSmaller_scalesDownToFitWidth
com.google.firebase.appdistribution.impl.ImageUtilsTest ‑ readScaledImage_targetIsGreaterThanHalf_returnsOriginal
…

com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ checkForNewRelease_failsWithNotImplemented
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ isTesterSignedIn_returnsFalse
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ signInTester_failsWithNotImplemented
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ signOutTester_doesNotThrow
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ updateApp
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ updateIfNewReleaseAvailable

♻️ This comment has been updated with latest results.

[google-oss-bot]

Coverage Report ¹

Affected Products

• firebase-appdistribution

  Overall coverage changed from 76.79% (5991287) to 79.31% (8bd3097) by +2.53%.

  Filename	Base (5991287)	Merge (8bd3097)	Diff
  FirebaseAppDistributionImpl.java	92.79%	94.90%	+2.11%
  FirebaseAppDistributionRegistrar.java	81.08%	92.59%	+11.51%

• firebase-appdistribution-api

  Overall coverage changed from 62.62% (5991287) to 64.42% (8bd3097) by +1.81%.

  Filename	Base (5991287)	Merge (8bd3097)	Diff
  FirebaseAppDistributionProxy.java	84.62%	100.00%	+15.38%
  FirebaseAppDistributionStub.java	81.40%	83.33%	+1.94%

Test Logs

• Base (5991287): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1549800266885238785
• Merge (8bd3097): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3926/check-coverage-changed/1549809454050971655

Notes

• Commit (8bd3097) is created by Prow via merging PR base commit (5991287) and head commit (68ff11e).
• Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

1. https://storage.googleapis.com/firebase-sdk-metric-reports/N1kDNBE3Pq.html

[google-oss-bot]

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.collectAndSendFeedback() [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

[google-oss-bot]

Size Report ¹

Affected Products

• firebase-appdistribution

  Type	Base (5991287)	Merge (8bd3097)	Diff
  aar	157 kB	145 kB	-11.7 kB (-7.5%)
  apk (aggressive)	880 kB	776 kB	-104 kB (-11.8%)
  apk (release)	2.01 MB	2.00 MB	-6.43 kB (-0.3%)

• firebase-appdistribution-api

  Type	Base (5991287)	Merge (8bd3097)	Diff
  aar	14.5 kB	14.4 kB	-93 B (-0.6%)
  apk (release)	697 kB	697 kB	-148 B (-0.0%)

Test Logs

• Base (5991287): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1549800266876850179
• Merge (8bd3097): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3926/binary-size/1549809454050971658

Notes

• Commit (8bd3097) is created by Prow via merging PR base commit (5991287) and head commit (68ff11e).

1. https://storage.googleapis.com/firebase-sdk-metric-reports/qBODe3Rjtm.html

[google-oss-bot]

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.collectAndSendFeedback() [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

[google-oss-bot]

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.collectAndSendFeedback() [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.