Skip to content

Revert "Remove In-App Feedback functionality from firebase-appdistribution (#3926) #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg commented Jul 20, 2022

This reverts commit 78d2888, merging it into fad-in-app-feedback.

This will establish the new feature branch for developing the In-App Feedback feature.

Copy link
Contributor

@jladieu jladieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions
Copy link
Contributor

Unit Test Results

150 tests  +15   150 ✔️ +15   44s ⏱️ -2s
  17 suites +  3       0 💤 ±  0 
  17 files   +  3       0 ±  0 

Results for commit 60919ee. ± Comparison against base commit 78d2888.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (78d2888) to 76.79% (feaea16) by ?.

    39 individual files with coverage change

    FilenameBase (78d2888)Merge (feaea16)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?30.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?0.00%?
    FeedbackSender.java?90.91%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?92.79%?
    FirebaseAppDistributionLifecycleNotifier.java?75.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?81.08%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?95.45%?
    InstallActivity.java?2.53%?
    LogWrapper.java?53.33%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?65.63%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?57.14%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.19%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

  • firebase-appdistribution-api

    Overall coverage changed from ? (78d2888) to 62.62% (feaea16) by ?.

    11 individual files with coverage change

    FilenameBase (78d2888)Merge (feaea16)Diff
    AppDistributionRelease.java?0.00%?
    BinaryType.java?0.00%?
    FirebaseAppDistribution.java?0.00%?
    FirebaseAppDistributionApiRegistrar.java?0.00%?
    FirebaseAppDistributionException.java?76.92%?
    FirebaseAppDistributionProxy.java?84.62%?
    FirebaseAppDistributionStub.java?81.40%?
    OnProgressListener.java?0.00%?
    UpdateProgress.java?0.00%?
    UpdateStatus.java?0.00%?
    UpdateTask.java?100.00%?

Test Logs

Notes

  • Commit (feaea16) is created by Prow via merging PR base commit (78d2888) and head commit (60919ee).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0A45bE6kjc.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (78d2888)Merge (feaea16)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-annotations

    TypeBase (78d2888)Merge (feaea16)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.88 kB? (?)
  • firebase-appdistribution

    TypeBase (78d2888)Merge (feaea16)Diff
    aar?157 kB? (?)
    apk (aggressive)?880 kB? (?)
    apk (release)?2.01 MB? (?)
  • firebase-appdistribution-api

    TypeBase (78d2888)Merge (feaea16)Diff
    aar?14.5 kB? (?)
    apk (aggressive)?85.5 kB? (?)
    apk (release)?697 kB? (?)
  • firebase-common

    TypeBase (78d2888)Merge (feaea16)Diff
    aar?48.6 kB? (?)
    apk (aggressive)?84.8 kB? (?)
    apk (release)?690 kB? (?)
  • firebase-components

    TypeBase (78d2888)Merge (feaea16)Diff
    aar?41.4 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?29.5 kB? (?)
  • firebase-installations

    TypeBase (78d2888)Merge (feaea16)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?86.4 kB? (?)
    apk (release)?712 kB? (?)
  • firebase-installations-interop

    TypeBase (78d2888)Merge (feaea16)Diff
    aar?8.34 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

Notes

  • Commit (feaea16) is created by Prow via merging PR base commit (78d2888) and head commit (60919ee).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/haiHrDTwtF.html

@lfkellogg
Copy link
Contributor Author

/test smoke-tests

@lfkellogg lfkellogg merged commit 0f24df5 into fad-in-app-feedback Jul 20, 2022
@lfkellogg lfkellogg deleted the revert-3926-lk/remove-in-app-feedback branch July 20, 2022 19:04
lfkellogg added a commit that referenced this pull request Aug 5, 2022
@firebase firebase locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants