Skip to content

fix perf apps unit tests #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2022
Merged

fix perf apps unit tests #3993

merged 1 commit into from
Aug 16, 2022

Conversation

vkryachko
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022 •
edited
Loading

Unit Test Results

   391 files  ±0     391 suites  ±0   17m 17s ⏱️ +11s
4 707 tests ±0  4 684 ✔️ +1  22 💤 ±0  1 ❌  - 1 
4 723 runs  ±0  4 700 ✔️ +1  22 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit 7e14f47. ± Comparison against base commit ba6f410.

♻️ This comment has been updated with latest results.

@vkryachko
Copy link
Member Author

/retest

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (ba6f410)Merge (60144b8)Diff
    aar1.26 MB1.26 MB-3 B (-0.0%)

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cikfJErKA1.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.15% (ba6f410) to 50.18% (60144b8) by +0.03%.

    FilenameBase (ba6f410)Merge (60144b8)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    QueryParams.java90.36%89.76%-0.60%

  • firebase-firestore

    Overall coverage changed from 45.92% (ba6f410) to 46.04% (60144b8) by +0.12%.

    FilenameBase (ba6f410)Merge (60144b8)Diff
    AbstractStream.java34.81%37.02%+2.21%
    AsyncQueue.java78.11%78.61%+0.50%
    Datastore.java29.76%32.14%+2.38%
    DeleteMutation.java90.48%95.24%+4.76%
    FirestoreChannel.java16.38%18.10%+1.72%
    FirestoreClient.java33.09%38.24%+5.15%
    GrpcCallProvider.java62.35%69.41%+7.06%
    IndexBackfiller.java89.06%93.75%+4.69%
    LruGarbageCollector.java90.65%93.46%+2.80%

Test Logs

Notes

  • Commit (60144b8) is created by Prow via merging PR base commit (ba6f410) and head commit (7e14f47).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/l84Izqzqo6.html

@vkryachko vkryachko requested review from rlazo and yifanyang August 16, 2022 15:14
rlazo
rlazo reviewed Aug 16, 2022
View reviewed changes
gradle/googleServices.gradle
// this is needed for storage test app to build
def hasStorageAppAssembleTask = taskName == ":firebase-storage:test-app:assembleRelease"
return hasProjectTestTask || hasStorageAppAssembleTask || taskName.contains('connectedCheck') || taskName.contains('deviceCheck') || taskName.contains('AndroidTest')
return hasProjectTestTask || taskName.contains('connectedCheck') || taskName.contains('deviceCheck') || taskName.contains('AndroidTest')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is no longer needed for storage app?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The storage app is disabled in the repo, and wouldn't work without secrets anyway, so I decided to remove this effectively "dead" code.

@vkryachko vkryachko merged commit d82eaa0 into master Aug 16, 2022
@vkryachko vkryachko deleted the vk.perf_app_check_fix branch August 16, 2022 17:15
@firebase firebase locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@yifanyang yifanyang Awaiting requested review from yifanyang

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkryachko @google-oss-bot @rlazo