Skip to content

fix perf apps unit tests #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2022
Merged

fix perf apps unit tests #3993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion firebase-perf/dev-app/dev-app.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
apply plugin: 'com.android.application'
// Firebase performance plugin, the relevant dependency is specified in the "buildSrc/build-src.gradle"
apply plugin: 'com.google.firebase.firebase-perf'
apply plugin: 'com.google.gms.google-services'
apply plugin: com.google.firebase.gradle.plugins.ci.device.FirebaseTestLabPlugin

firebaseTestLab {
Expand Down
1 change: 0 additions & 1 deletion firebase-perf/e2e-app/e2e-app.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
apply plugin: 'com.android.application'
// Firebase performance plugin, the relevant dependency is specified in the "buildSrc/build-src.gradle"
apply plugin: 'com.google.firebase.firebase-perf'
apply plugin: 'com.google.gms.google-services'
apply plugin: com.google.firebase.gradle.plugins.ci.device.FirebaseTestLabPlugin

// Since Test Lab devices are wiped off immediately (for both Security and Privacy reasons) we have
Expand Down
4 changes: 1 addition & 3 deletions gradle/googleServices.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,7 @@ afterEvaluate {
def isTesting = getGradle().getStartParameter().getTaskNames().any({ String taskName ->
def hasProjectTestTask = taskName.contains("$name") && ['AndroidTest', 'connectedCheck', 'deviceCheck'].any({ taskName.contains(it)})

// this is needed for storage test app to build
def hasStorageAppAssembleTask = taskName == ":firebase-storage:test-app:assembleRelease"
return hasProjectTestTask || hasStorageAppAssembleTask || taskName.contains('connectedCheck') || taskName.contains('deviceCheck') || taskName.contains('AndroidTest')
return hasProjectTestTask || taskName.contains('connectedCheck') || taskName.contains('deviceCheck') || taskName.contains('AndroidTest')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is no longer needed for storage app?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The storage app is disabled in the repo, and wouldn't work without secrets anyway, so I decided to remove this effectively "dead" code.

})

if (isTesting) {
Expand Down