prepare for translation #4467

kaibolay · 2022-12-19T22:15:01Z

removed unused strings
extracted hard-coded strings
added translation_description

…scription.

google-oss-bot · 2022-12-19T22:15:38Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2022-12-19T22:19:50Z

Coverage Report ¹

Affected Products

No changes between base commit (12be9d7) and merge commit (7b81e69).

Test Logs

Merge (7b81e69): https://github.com/firebase/firebase-android-sdk/actions/runs/3741674114

https://storage.googleapis.com/firebase-sdk-metric-reports/6Wcu83S0jz.html

github-actions · 2022-12-19T22:21:47Z

Unit Test Results

  389 files +  310   389 suites +310 18m 44s ⏱️ + 17m 54s
4 629 tests +3 517 4 606 ✔️ +3 510 22 💤 +6 1 ❌ +1
4 645 runs +3 533 4 622 ✔️ +3 526 22 💤 +6 1 ❌ +1

For more details on these failures, see this check.

Results for commit ab9de46. ± Comparison against base commit aa923f7.

♻️ This comment has been updated with latest results.

VictoriaAuto · 2022-12-19T22:55:01Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="singin_yes_button">Turn on</string>
-  <string name="singin_no_button">Not now</string>
-  <string name="no_update_available">No new release available, try calling checkForUpdate.</string>
-  <string name="update_dialog_title">New Version Available</string>


lowercase "version available"

VictoriaAuto · 2022-12-19T22:57:02Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="app_update_notification_channel_description">Shows progress of in-app updates</string>
-  <string name="feedback_launch_failed">Failed to launch feedback</string>
-  <string name="feedback_unidentified_release">Release not found. This app may not have been installed by App Distribution, or you may no longer have access.</string>
-  <string name="feedback_no_release">Would have sent feedback, but did not due to development mode.</string>


Is this due to the Developer Mode issue? Is there a way to rephrase this such that the user knows what happened and how to resolve the issue? Perhaps "Feedback not sent due to development mode." Will users know what development mode means, and what they need to do to resolve this issue?

No, this is not about the iOS development mode.

It's about the local development mode for the SDK explained in the EAP feedback guide.

Testers will not encounter this. Only developers who test the SDK will see this.

Since it's a "toast" the message needs to be pretty brief. I think it's probably fine as-is.

VictoriaAuto · 2022-12-19T22:57:43Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="feedback_unidentified_release">Release not found. This app may not have been installed by App Distribution, or you may no longer have access.</string>
-  <string name="feedback_no_release">Would have sent feedback, but did not due to development mode.</string>
-  <string name="feedback_notification_channel_name">Feedback</string>
-  <string name="feedback_notification_channel_description">Tap to leave feedback</string>


Recommend replacing "leave" with "enter"

VictoriaAuto · 2022-12-19T22:58:05Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="feedback_notification_channel_description">Tap to leave feedback</string>
-  <string name="feedback_notification_title">We want your feedback!</string>
-  <string name="feedback_notification_text">Tap to leave feedback for %1$s</string>
-  <string name="unknown_sources_dialog_title">Enable Unknown Sources</string>


Is "Unknown Sources" a field name? If not, use lowercase here.

My Android version calls this setting "Install unknown apps". That's actually pretty nonsensical. I think it's a pretty bad change in the Android OS. The apps being installed are not "unknown".

The setting used to be called "Unknown sources" with the subtitle "Allow installation of apps from unknown sources".

I've updated this title and the associated message.

VictoriaAuto · 2022-12-19T22:59:14Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="send_feedback">Send feedback</string>
-  <string name="send_button_description">Send</string>
-  <string name="sender">From: %1$s</string>
-  <string name="feedback_text_hint">Have feedback? Let us know how we can make this app better.</string>


Replace with "Have feedback? Tell us how we can improve this app."

VictoriaAuto · 2022-12-19T23:00:44Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="update_yes_button">Update</string>
-  <string name="update_no_button">Cancel</string>
-  <string name="downloading_app_update">Downloading in-app update…</string>
-  <string name="download_completed">Download completed</string>


Replace "completed" with "complete"

VictoriaAuto · 2022-12-19T23:02:33Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="feedback_notification_title">We want your feedback!</string>
-  <string name="feedback_notification_text">Tap to leave feedback for %1$s</string>
-  <string name="unknown_sources_dialog_title">Enable Unknown Sources</string>
-  <string name="unknown_sources_dialog_description">To install the update enable unknown sources</string>


Add a comma after "To install the update"

VictoriaAuto · 2022-12-19T23:07:36Z

firebase-appdistribution/src/main/res/values/strings.xml

@@ -13,40 +13,37 @@
 <!-- limitations under the License. -->

 <resources>
-  <string name="signin_dialog_title">Enable testing features</string>
-  <string name="singin_dialog_message">Enable testing features like new build alerts and in-app feedback.</string>
-  <string name="singin_yes_button">Turn on</string>


Why not "Enable"?

VictoriaAuto · 2022-12-19T23:08:25Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="signin_dialog_title">Enable testing features</string>
-  <string name="singin_dialog_message">Enable testing features like new build alerts and in-app feedback.</string>
-  <string name="singin_yes_button">Turn on</string>
-  <string name="singin_no_button">Not now</string>


Would "Cancel" be more appropriate here, if it's canceling an action?

The action (trying to enable the SDK) was likely not taken by the user in this case. It is typically triggered by the developer when the app is first opened.

If left this as-is for now.

VictoriaAuto

Hi Kai, I reviewed the strings and left some comments. Let me know if you have any questions about my feedback. Thank you! :-)

lfkellogg · 2022-12-20T13:51:56Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="signin_dialog_title">Enable testing features</string>
-  <string name="singin_dialog_message">Enable testing features like new build alerts and in-app feedback.</string>
-  <string name="singin_yes_button">Turn on</string>
-  <string name="singin_no_button">Not now</string>


The action (trying to enable the SDK) was likely not taken by the user in this case. It is typically triggered by the developer when the app is first opened.

lfkellogg · 2022-12-20T13:53:00Z

firebase-appdistribution/src/main/res/values/strings.xml

-  <string name="screenshot">Screenshot</string>
-  <string name="no_screenshot">Screenshot (not available)</string>
-  <string name="screenshot_image_description">Screenshot image</string>
+  <string name="signin_dialog_title" translation_description="Title of the dialog encouraging the user to enable Firebase App-Distribution features">Enable testing features</string>


Nit: don't hyphenate App Distribution :)

lfkellogg · 2022-12-20T13:56:20Z

firebase-appdistribution/src/main/res/values/strings.xml

+  <string name="feedback_notification_channel_name" translation_description="Name of the notification channel for in-app feedback">Feedback</string>
+  <string name="feedback_notification_channel_description" translation_description="Description of the notification channel for in-app feedback">Shows notification to leave feedback about app</string>
+  <string name="feedback_notification_title" translation_description="Title of notification encouraging testers to leave feedback">We want your feedback!</string>
+  <string name="feedback_notification_text" translation_description="Text of notification encouraging testers to leave feedback">Tap to leave feedback for %1$s</string>


Nit: how about "... to leave feedback for the app" just so it's clear what the placeholder represents.

lfkellogg · 2022-12-20T13:57:40Z

firebase-appdistribution/src/main/res/values/strings.xml

+  <string name="back_button_description" translation_description="Description for image button (back) which aborts feedback">Back</string>
+  <string name="send_feedback" translation_description="Text next to send button which sends feedback">Send feedback</string>
+  <string name="send_button_description" translation_description="Description of image button (send) which sends feedback">Send</string>
+  <string name="feexdback_text_hint" translation_description="">Have feedback? Let us know how we can make this app better.</string>


The last 4 need translation_descriptions

Ugh, those got lost in a bad merge. Restored.

google-oss-bot · 2022-12-20T15:24:14Z

Size Report ¹

Affected Products

base
Type Base (12be9d7) Merge (7b81e69) Diff
apk (aggressive) ? 8.39 kB ? (?)
apk (release) ? 8.65 kB ? (?)
firebase-annotations
Type Base (12be9d7) Merge (7b81e69) Diff
apk (aggressive) ? 8.39 kB ? (?)
apk (release) ? 9.46 kB ? (?)
firebase-appdistribution
Type Base (12be9d7) Merge (7b81e69) Diff
aar ? 146 kB ? (?)
apk (aggressive) ? 830 kB ? (?)
apk (release) ? 2.01 MB ? (?)
firebase-appdistribution-api
Type Base (12be9d7) Merge (7b81e69) Diff
aar ? 16.0 kB ? (?)
apk (aggressive) ? 95.8 kB ? (?)
apk (release) ? 708 kB ? (?)
firebase-common
Type Base (12be9d7) Merge (7b81e69) Diff
aar ? 67.4 kB ? (?)
apk (aggressive) ? 95.1 kB ? (?)
apk (release) ? 700 kB ? (?)
firebase-components
Type Base (12be9d7) Merge (7b81e69) Diff
aar ? 44.9 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 33.6 kB ? (?)
firebase-installations
Type Base (12be9d7) Merge (7b81e69) Diff
aar ? 55.0 kB ? (?)
apk (aggressive) ? 96.6 kB ? (?)
apk (release) ? 724 kB ? (?)
firebase-installations-interop
Type Base (12be9d7) Merge (7b81e69) Diff
aar ? 8.05 kB ? (?)
apk (aggressive) ? 65.0 kB ? (?)
apk (release) ? 651 kB ? (?)

Test Logs

Merge (7b81e69): https://github.com/firebase/firebase-android-sdk/actions/runs/3741674114

https://storage.googleapis.com/firebase-sdk-metric-reports/lXmvSRNXpt.html

google-oss-bot · 2022-12-20T15:35:10Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (7b81e69) and the base commit (12be9d7) are not available.

No macrobenchmark data found for the base commit (12be9d7). Analysis for the CI merge commit (7b81e69) can be found at:

https://storage.googleapis.com/firebase-sdk-metric-reports/UmBMxFZcNQ/index.html

https://storage.googleapis.com/firebase-sdk-metric-reports/wir0mbxtxF/index.html

- Remove unused strings - extract hard-coded strings - add translation_description

Remove unused strings, extract hard-coded strings, add translation_de…

ab9de46

…scription.

kaibolay requested a review from VictoriaAuto December 19, 2022 22:15

google-oss-bot added the size/M label Dec 19, 2022

VictoriaAuto reviewed Dec 19, 2022

View reviewed changes

VictoriaAuto suggested changes Dec 19, 2022

View reviewed changes

lfkellogg reviewed Dec 20, 2022

View reviewed changes

Incorporate feedback

63af9f1

lfkellogg approved these changes Dec 20, 2022

View reviewed changes

kaibolay merged commit 776e1d4 into fad/in-app-feedback Dec 20, 2022

kaibolay deleted the kb/i18n branch December 20, 2022 15:09

lfkellogg pushed a commit that referenced this pull request Dec 20, 2022

prepare for translation (#4467)

945cc63

- Remove unused strings - extract hard-coded strings - add translation_description

lfkellogg pushed a commit that referenced this pull request Jan 5, 2023

prepare for translation (#4467)

eadf5c0

- Remove unused strings - extract hard-coded strings - add translation_description

firebase locked and limited conversation to collaborators Jan 20, 2023

prepare for translation #4467

prepare for translation #4467

Uh oh!

Conversation

kaibolay commented Dec 19, 2022

Uh oh!

google-oss-bot commented Dec 19, 2022

Uh oh!

google-oss-bot commented Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

Test Logs

Uh oh!

github-actions bot commented Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VictoriaAuto Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VictoriaAuto Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VictoriaAuto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-oss-bot commented Dec 20, 2022

Size Report 1

Affected Products

google-oss-bot commented Dec 19, 2022 •

edited

Loading

Coverage Report ¹

github-actions bot commented Dec 19, 2022 •

edited

Loading

VictoriaAuto Dec 19, 2022 •

edited

Loading

VictoriaAuto Dec 19, 2022 •

edited

Loading

Size Report ¹

`base`

`firebase-annotations`

`firebase-appdistribution`

`firebase-appdistribution-api`

`firebase-common`

`firebase-components`

`firebase-installations`

`firebase-installations-interop`

Startup Time Report ¹