Skip to content

prepare for translation #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2022
Merged

prepare for translation #4467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab9de46
Remove unused strings, extract hard-coded strings, add translation_de…
kaibolay Dec 19, 2022
63af9f1
Incorporate feedback
kaibolay Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...n/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,11 +523,16 @@ private Task<Void> showUpdateConfirmationDialog(
StringBuilder message =
new StringBuilder(
String.format(
"Version %s (%s) is available.",
newRelease.getDisplayVersion(), newRelease.getVersionCode()));
context.getString(R.string.update_version_available),
newRelease.getDisplayVersion(),
newRelease.getVersionCode()));

if (newRelease.getReleaseNotes() != null && !newRelease.getReleaseNotes().isEmpty()) {
message.append(String.format("\n\nRelease notes: %s", newRelease.getReleaseNotes()));
message
.append("\n\n")
.append(context.getString(R.string.update_release_notes))
.append(" ")
.append(newRelease.getReleaseNotes());
}
updateConfirmationDialog.setMessage(message);

Expand Down
69 changes: 33 additions & 36 deletions firebase-appdistribution/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,40 +13,37 @@
<!-- limitations under the License. -->

<resources>
<string name="signin_dialog_title">Enable testing features</string>
<string name="singin_dialog_message">Enable testing features like new build alerts and in-app feedback.</string>
<string name="singin_yes_button">Turn on</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "Enable"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<string name="singin_no_button">Not now</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "Cancel" be more appropriate here, if it's canceling an action?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action (trying to enable the SDK) was likely not taken by the user in this case. It is typically triggered by the developer when the app is first opened.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If left this as-is for now.

<string name="no_update_available">No new release available, try calling checkForUpdate.</string>
<string name="update_dialog_title">New Version Available</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase "version available"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<string name="update_yes_button">Update</string>
<string name="update_no_button">Cancel</string>
<string name="downloading_app_update">Downloading in-app update…</string>
<string name="download_completed">Download completed</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "completed" with "complete"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<string name="download_failed">Download failed</string>
<string name="download_pending">Download pending</string>
<string name="install_failed">Install failed</string>
<string name="install_canceled">Install canceled</string>
<string name="update_canceled">Update canceled </string>
<string name="notifications_group_name">Firebase App Distribution</string>
<string name="app_update_notification_channel_name">App updates</string>
<string name="app_update_notification_channel_description">Shows progress of in-app updates</string>
<string name="feedback_launch_failed">Failed to launch feedback</string>
<string name="feedback_unidentified_release">Release not found. This app may not have been installed by App Distribution, or you may no longer have access.</string>
<string name="feedback_no_release">Would have sent feedback, but did not due to development mode.</string>
Copy link

@VictoriaAuto VictoriaAuto Dec 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this due to the Developer Mode issue? Is there a way to rephrase this such that the user knows what happened and how to resolve the issue? Perhaps "Feedback not sent due to development mode." Will users know what development mode means, and what they need to do to resolve this issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is not about the iOS development mode.

It's about the local development mode for the SDK explained in the EAP feedback guide.

Testers will not encounter this. Only developers who test the SDK will see this.

Since it's a "toast" the message needs to be pretty brief. I think it's probably fine as-is.

<string name="feedback_notification_channel_name">Feedback</string>
<string name="feedback_notification_channel_description">Tap to leave feedback</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend replacing "leave" with "enter"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<string name="feedback_notification_title">We want your feedback!</string>
<string name="feedback_notification_text">Tap to leave feedback for %1$s</string>
<string name="unknown_sources_dialog_title">Enable Unknown Sources</string>
Copy link

@VictoriaAuto VictoriaAuto Dec 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Unknown Sources" a field name? If not, use lowercase here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Android version calls this setting "Install unknown apps". That's actually pretty nonsensical. I think it's a pretty bad change in the Android OS. The apps being installed are not "unknown".

The setting used to be called "Unknown sources" with the subtitle "Allow installation of apps from unknown sources".

I've updated this title and the associated message.

<string name="unknown_sources_dialog_description">To install the update enable unknown sources</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comma after "To install the update"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<string name="unknown_sources_yes_button">Settings</string>
<string name="back_button_description">Back</string>
<string name="send_feedback">Send feedback</string>
<string name="send_button_description">Send</string>
<string name="sender">From: %1$s</string>
<string name="feedback_text_hint">Have feedback? Let us know how we can make this app better.</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with "Have feedback? Tell us how we can improve this app."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<string name="screenshot">Screenshot</string>
<string name="no_screenshot">Screenshot (not available)</string>
<string name="screenshot_image_description">Screenshot image</string>
<string name="signin_dialog_title" translation_description="Title of the dialog encouraging the user to enable Firebase App Distribution features">Enable testing features</string>
<string name="singin_dialog_message" translation_description="Content of the dialog encouraging the user to enable Firebase App Distribution features">Enable testing features like new build alerts and in-app feedback.</string>
<string name="singin_yes_button" translation_description="Text on button to enable Firebase App Distribution features">Enable</string>
<string name="singin_no_button" translation_description="Text on button to decline Firebase App Distribution features">Not now</string>
<string name="update_dialog_title" translation_description="Title of the dialog explaining to the user that a new version of the application is available">New version available</string>
<string name="update_version_available" translation_description="Version string (and code) of the available update">Version %1$s (%2$d) is available.</string>
<string name="update_release_notes" translation_description="Text prefixing release notes">Release notes:</string>
<string name="update_yes_button" translation_description="Text on button to start update">Update</string>
<string name="update_no_button" translation_description="Text on button to cancel update">Cancel</string>
<string name="downloading_app_update" translation_description="Title of the notification showing during download of update">Downloading in-app update…</string>
<string name="download_completed" translation_description="Title of notification when download of update has completed">Download complete</string>
<string name="download_failed" translation_description="Title of notification when download of update has failed">Download failed</string>
<string name="install_failed" translation_description="Title of notification when installation of update has failed">Install failed</string>
<string name="notifications_group_name" translation_description="Title of the notification channel group for the SDK">Firebase App Distribution</string>
<string name="app_update_notification_channel_name" translation_description="Name of the notification channel for in-app updates">App updates</string>
<string name="app_update_notification_channel_description" translation_description="Description of the notification channel for in-app updates">Shows progress of in-app updates</string>
<string name="feedback_launch_failed" translation_description="Toast explaining that launching the feedback functionality failed">Failed to launch feedback</string>
<string name="feedback_unidentified_release" translation_description="Toast explaining feedback can't be provided, because release can't be found">Release not found. This app may not have been installed by App Distribution, or you may no longer have access.</string>
<string name="feedback_no_release" translation_description="Toast explaining that feedback would have been sent, but was not, since development mode was active">Would have sent feedback, but did not due to development mode.</string>
<string name="feedback_notification_channel_name" translation_description="Name of the notification channel for in-app feedback">Feedback</string>
<string name="feedback_notification_channel_description" translation_description="Description of the notification channel for in-app feedback">Shows notification to enter feedback about app</string>
<string name="feedback_notification_title" translation_description="Title of notification encouraging testers to enter feedback">We want your feedback!</string>
<string name="feedback_notification_text" translation_description="Text of notification encouraging testers to enter feedback for the app">Tap to enter feedback for %1$s</string>
<string name="unknown_sources_dialog_title" translation_description="Title of dialog describing that installation from unknown sources needs to be enabled">Installation from unknown Sources</string>
<string name="unknown_sources_dialog_description" translation_description="Text of dialog describing why installation from unknown sources needs to be enabled">To install the update, enable installation from unknown sources</string>
<string name="unknown_sources_yes_button" translation_description="Label on button launching settings to enable installation from unknown sources">Settings</string>
<string name="back_button_description" translation_description="Description for image button (back) which aborts feedback">Back</string>
<string name="send_feedback" translation_description="Text next to send button which sends feedback">Send feedback</string>
<string name="send_button_description" translation_description="Description of image button (send) which sends feedback">Send</string>
<string name="feedback_text_hint" translation_description="Default text hint displayed in the text box where user should type their feedback">Have feedback? Let us know how we can make this app better.</string>
<string name="screenshot" translation_description="Text displayed next to the checkbox which can be toggled to include/exclude a screenshot with the feedback">Screenshot</string>
<string name="no_screenshot" translation_description="Text displayed when there is no screenshot available to be included with the feedback">Screenshot (not available)</string>
<string name="screenshot_image_description" translation_description="Description for the screenshot image">Screenshot image</string>
</resources>