Skip to content

Davidmotson.pin versions #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 10, 2023
Merged

Davidmotson.pin versions #4697

merged 17 commits into from
Mar 10, 2023

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

Javadoc Changes:
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/FirebaseApp.html	2023-03-09 23:33:53.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/FirebaseApp.html	2023-03-09 23:28:11.000000000 +0000
@@ -15,7 +15,7 @@
     <p>For a vast majority of apps, <code><a href="/docs/reference/android/com/google/firebase/provider/FirebaseInitProvider.html">FirebaseInitProvider</a></code> will handle the initialization of Firebase for the default project that it's configured to work with, via the data contained in the app's <code>google-services.json</code> file. This <code>
  ContentProvider</code> is merged into the app's manifest by default when building with Gradle, and it runs automatically at app launch. <b>No additional lines of code are needed in this case.</b></p>
     <p>In the event that an app requires access to another Firebase project <b>in addition to</b> the default project, <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html#initializeApp(android.content.Context,com.google.firebase.FirebaseOptions,java.lang.String)">initializeApp</a></code> must be used to create that relationship programmatically. The name parameter must be unique. To connect to the resources exposed by that project, use the <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> object returned by <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html#getInstance(java.lang.String)">getInstance</a></code>, passing it the same name used with <code>
- initializeApp</code>. This object must be passed to the static accessor of the feature that provides the resource. For example, <code><a href="/docs/reference/android/com/google/firebase/storage/FirebaseStorage.html#getInstance(com.google.firebase.FirebaseApp)">getInstance</a></code> is used to access the storage bucket provided by the additional project, whereas <code><a href="/docs/reference/android/com/google/firebase/storage/FirebaseStorage.html#getInstance()">getInstance</a></code> is used to access the default project. </p>
+ initializeApp</code>. This object must be passed to the static accessor of the feature that provides the resource. For example, getInstance is used to access the storage bucket provided by the additional project, whereas getInstance is used to access the default project. </p>
     <p>Any <code>FirebaseApp</code> initialization must occur only in the main process of the app. Use of Firebase in processes other than the main process is not supported and will likely cause problems related to resource contention.</p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/FirebaseApp.html	2023-03-09 23:33:53.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/FirebaseApp.html	2023-03-09 23:28:11.000000000 +0000
@@ -15,7 +15,7 @@
     <p>For a vast majority of apps, <code><a href="/docs/reference/kotlin/com/google/firebase/provider/FirebaseInitProvider.html">FirebaseInitProvider</a></code> will handle the initialization of Firebase for the default project that it's configured to work with, via the data contained in the app's <code>google-services.json</code> file. This <code>
  ContentProvider</code> is merged into the app's manifest by default when building with Gradle, and it runs automatically at app launch. <b>No additional lines of code are needed in this case.</b></p>
     <p>In the event that an app requires access to another Firebase project <b>in addition to</b> the default project, <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html#initializeApp(android.content.Context,com.google.firebase.FirebaseOptions,java.lang.String)">initializeApp</a></code> must be used to create that relationship programmatically. The name parameter must be unique. To connect to the resources exposed by that project, use the <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> object returned by <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html#getInstance(java.lang.String)">getInstance</a></code>, passing it the same name used with <code>
- initializeApp</code>. This object must be passed to the static accessor of the feature that provides the resource. For example, <code><a href="/docs/reference/kotlin/com/google/firebase/storage/FirebaseStorage.html#getInstance(com.google.firebase.FirebaseApp)">getInstance</a></code> is used to access the storage bucket provided by the additional project, whereas <code><a href="/docs/reference/kotlin/com/google/firebase/storage/FirebaseStorage.html#getInstance()">getInstance</a></code> is used to access the default project. </p>
+ initializeApp</code>. This object must be passed to the static accessor of the feature that provides the resource. For example, getInstance is used to access the storage bucket provided by the additional project, whereas getInstance is used to access the default project. </p>
     <p>Any <code>FirebaseApp</code> initialization must occur only in the main process of the app. Use of Firebase in processes other than the main process is not supported and will likely cause problems related to resource contention.</p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2023

Unit Test Results

   772 files  +  11     772 suites  +11   32m 52s ⏱️ + 1m 18s
4 806 tests ±    0  4 785 ✔️ +    2  21 💤 ±0  0  - 2 
9 409 runs  +359  9 367 ✔️ +361  42 💤 ±0  0  - 2 

Results for commit f782b0a. ± Comparison against base commit dfe71a9.

♻️ This comment has been updated with latest results.

@davidmotson davidmotson force-pushed the davidmotson.pin_versions branch from 21cbe7a to 021d33f Compare February 18, 2023 00:25
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 18, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2023

Size Report 1

Affected Products

  • firebase-abt

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)116 kB116 kB+377 B (+0.3%)
    apk (release)1.27 MB1.27 MB-2.06 kB (-0.2%)
  • firebase-appcheck

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)361 kB362 kB+377 B (+0.1%)
    apk (release)1.56 MB1.56 MB-1.80 kB (-0.1%)
  • firebase-appcheck-debug

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)362 kB363 kB+373 B (+0.1%)
    apk (release)1.56 MB1.56 MB-1.62 kB (-0.1%)
  • firebase-appcheck-debug-testing

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)364 kB365 kB+377 B (+0.1%)
    apk (release)1.60 MB1.60 MB-1.94 kB (-0.1%)
  • firebase-appcheck-interop

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)358 kB358 kB+373 B (+0.1%)
    apk (release)1.54 MB1.54 MB-1.82 kB (-0.1%)
  • firebase-appcheck-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    aar5.98 kB5.98 kB-1 B (-0.0%)
    apk (aggressive)369 kB370 kB+377 B (+0.1%)
    apk (release)1.94 MB1.94 MB-2.09 kB (-0.1%)
  • firebase-appcheck-playintegrity

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)365 kB365 kB+373 B (+0.1%)
    apk (release)1.57 MB1.57 MB-1.83 kB (-0.1%)
  • firebase-appcheck-safetynet

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)364 kB364 kB+373 B (+0.1%)
    apk (release)1.57 MB1.57 MB-811 B (-0.1%)
  • firebase-appdistribution

    TypeBase (dfe71a9)Merge (3150a76)Diff
    aar241 kB241 kB+65 B (+0.0%)
    apk (aggressive)903 kB903 kB+596 B (+0.1%)
    apk (release)2.63 MB2.63 MB-572 B (-0.0%)
  • firebase-appdistribution-api

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)112 kB112 kB+373 B (+0.3%)
    apk (release)1.27 MB1.27 MB-2.22 kB (-0.2%)
  • firebase-appdistribution-api-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    aar5.85 kB5.85 kB-2 B (-0.0%)
    apk (aggressive)124 kB124 kB+377 B (+0.3%)
    apk (release)1.65 MB1.65 MB-3.10 kB (-0.2%)
  • firebase-common

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)111 kB112 kB+373 B (+0.3%)
    apk (release)1.26 MB1.26 MB+373 B (+0.0%)
  • firebase-common-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)123 kB123 kB+373 B (+0.3%)
    apk (release)1.64 MB1.64 MB+373 B (+0.0%)
  • firebase-components

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)23.1 kB23.3 kB+189 B (+0.8%)
    apk (release)596 kB596 kB+189 B (+0.0%)
  • firebase-config

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)125 kB126 kB+592 B (+0.5%)
    apk (release)1.32 MB1.32 MB-2.30 kB (-0.2%)
  • firebase-config-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)134 kB135 kB+596 B (+0.4%)
    apk (release)1.70 MB1.70 MB-2.09 kB (-0.1%)
  • firebase-crashlytics

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)245 kB246 kB+1.34 kB (+0.5%)
    apk (release)1.48 MB1.48 MB-2.05 kB (-0.1%)
  • firebase-crashlytics-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)252 kB254 kB+1.33 kB (+0.5%)
    apk (release)1.86 MB1.86 MB-1.44 kB (-0.1%)
  • firebase-crashlytics-ndk

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive / arm64-v8a)1.41 MB1.41 MB+1.34 kB (+0.1%)
    apk (aggressive / armeabi-v7a)889 kB890 kB+1.34 kB (+0.2%)
    apk (aggressive / x86)1.39 MB1.40 MB+1.34 kB (+0.1%)
    apk (aggressive / x86_64)1.46 MB1.46 MB+1.34 kB (+0.1%)
    apk (release / arm64-v8a)2.64 MB2.64 MB-2.77 kB (-0.1%)
    apk (release / armeabi-v7a)2.12 MB2.12 MB-2.77 kB (-0.1%)
    apk (release / x86)2.62 MB2.62 MB-2.77 kB (-0.1%)
    apk (release / x86_64)2.69 MB2.68 MB-2.77 kB (-0.1%)
  • firebase-database

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)359 kB360 kB+792 B (+0.2%)
    apk (release)1.72 MB1.72 MB-1.65 kB (-0.1%)
  • firebase-database-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)367 kB368 kB+788 B (+0.2%)
    apk (release)2.11 MB2.10 MB-1.39 kB (-0.1%)
  • firebase-datatransport

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (release)1.35 MB1.35 MB-2.28 kB (-0.2%)
  • firebase-dynamic-links

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)360 kB360 kB+373 B (+0.1%)
    apk (release)1.56 MB1.56 MB-1.63 kB (-0.1%)
  • firebase-dynamic-links-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)368 kB368 kB+377 B (+0.1%)
    apk (release)1.94 MB1.94 MB-1.43 kB (-0.1%)
  • firebase-dynamic-module-support

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)124 kB124 kB+373 B (+0.3%)
    apk (release)1.32 MB1.31 MB-2.11 kB (-0.2%)
  • firebase-encoders-json

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)8.68 kB8.86 kB+182 B (+2.1%)
    apk (release)20.1 kB20.3 kB+182 B (+0.9%)
  • firebase-encoders-proto

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)8.68 kB8.86 kB+182 B (+2.1%)
    apk (release)21.6 kB21.7 kB+178 B (+0.8%)
  • firebase-encoders-reflective

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)8.68 kB9.06 kB+377 B (+4.3%)
    apk (release)22.2 kB22.5 kB+369 B (+1.7%)
  • firebase-firestore

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)517 kB518 kB+788 B (+0.2%)
    apk (release)3.94 MB3.93 MB-2.44 kB (-0.1%)
  • firebase-firestore-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)526 kB527 kB+792 B (+0.2%)
    apk (release)4.32 MB4.32 MB-2.38 kB (-0.1%)
  • firebase-functions

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)400 kB400 kB+583 B (+0.1%)
    apk (release)1.82 MB1.81 MB-1.26 kB (-0.1%)
  • firebase-functions-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)408 kB409 kB+579 B (+0.1%)
    apk (release)2.20 MB2.19 MB-1.32 kB (-0.1%)
  • firebase-inappmessaging

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)698 kB698 kB+358 B (+0.1%)
    apk (release)3.95 MB3.95 MB-2.57 kB (-0.1%)
  • firebase-inappmessaging-display

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)1.53 MB1.53 MB+418 B (+0.0%)
    apk (release)5.21 MB5.21 MB-2.27 kB (-0.0%)
  • firebase-inappmessaging-display-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)1.54 MB1.54 MB+378 B (+0.0%)
    apk (release)5.59 MB5.59 MB-754 B (-0.0%)
  • firebase-inappmessaging-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)706 kB706 kB+374 B (+0.1%)
    apk (release)4.34 MB4.33 MB-2.37 kB (-0.1%)
  • firebase-installations

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)118 kB114 kB-3.50 kB (-3.0%)
    apk (release)1.29 MB1.28 MB-3.00 kB (-0.2%)
  • firebase-installations-interop

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)65.0 kB65.2 kB+189 B (+0.3%)
    apk (release)651 kB652 kB+189 B (+0.0%)
  • firebase-installations-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)126 kB127 kB+592 B (+0.5%)
    apk (release)1.67 MB1.67 MB-1.76 kB (-0.1%)
  • firebase-messaging

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)464 kB465 kB+418 B (+0.1%)
    apk (release)1.72 MB1.72 MB-3.35 kB (-0.2%)
  • firebase-messaging-directboot

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)465 kB465 kB+418 B (+0.1%)
    apk (release)1.72 MB1.72 MB-2.55 kB (-0.1%)
  • firebase-messaging-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)472 kB472 kB+414 B (+0.1%)
    apk (release)2.10 MB2.10 MB-2.85 kB (-0.1%)
  • firebase-ml-modeldownloader

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)167 kB168 kB+414 B (+0.2%)
    apk (release)1.41 MB1.41 MB-2.20 kB (-0.2%)
  • firebase-ml-modeldownloader-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)175 kB176 kB+414 B (+0.2%)
    apk (release)1.79 MB1.79 MB-2.68 kB (-0.1%)
  • firebase-perf

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)1.06 MB957 kB-102 kB (-9.7%)
    apk (release)3.06 MB2.95 MB-105 kB (-3.4%)
  • firebase-perf-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)1.07 MB965 kB-102 kB (-9.6%)
    apk (release)3.44 MB3.34 MB-104 kB (-3.0%)
  • firebase-storage

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)359 kB359 kB+579 B (+0.2%)
    apk (release)1.59 MB1.59 MB-1.95 kB (-0.1%)
  • firebase-storage-ktx

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)367 kB367 kB+583 B (+0.2%)
    apk (release)1.97 MB1.97 MB-1.68 kB (-0.1%)
  • transport-backend-cct

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)58.2 kB57.6 kB-567 B (-1.0%)
    apk (release)105 kB105 kB-555 B (-0.5%)
  • transport-runtime

    TypeBase (dfe71a9)Merge (3150a76)Diff
    apk (aggressive)44.0 kB44.6 kB+548 B (+1.2%)
    apk (release)83.5 kB84.0 kB+560 B (+0.7%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AYDFAGZg3B.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2023

Startup Time Report 1

The report is too large (117,141 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lXImn6pwZM/index.html

@davidmotson
Copy link
Collaborator Author

/retest

@davidmotson davidmotson requested a review from VinayGuthal March 3, 2023 20:17
@davidmotson davidmotson closed this Mar 6, 2023
@davidmotson davidmotson reopened this Mar 6, 2023
@davidmotson davidmotson requested a review from daymxn March 9, 2023 21:02
@daymxn
Copy link
Member

daymxn commented Mar 9, 2023

LGTM, but I differ final approval to @rlazo

@davidmotson davidmotson enabled auto-merge (squash) March 10, 2023 17:21
@davidmotson davidmotson disabled auto-merge March 10, 2023 17:21
@davidmotson davidmotson merged commit 436b03f into master Mar 10, 2023
@davidmotson davidmotson deleted the davidmotson.pin_versions branch March 10, 2023 17:21
@firebase firebase locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants