-
Notifications
You must be signed in to change notification settings - Fork 625
Davidmotson.pin versions #4697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Davidmotson.pin versions #4697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/FirebaseApp.html 2023-03-09 23:33:53.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/FirebaseApp.html 2023-03-09 23:28:11.000000000 +0000
@@ -15,7 +15,7 @@
<p>For a vast majority of apps, <code><a href="/docs/reference/android/com/google/firebase/provider/FirebaseInitProvider.html">FirebaseInitProvider</a></code> will handle the initialization of Firebase for the default project that it's configured to work with, via the data contained in the app's <code>google-services.json</code> file. This <code>
ContentProvider</code> is merged into the app's manifest by default when building with Gradle, and it runs automatically at app launch. <b>No additional lines of code are needed in this case.</b></p>
<p>In the event that an app requires access to another Firebase project <b>in addition to</b> the default project, <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html#initializeApp(android.content.Context,com.google.firebase.FirebaseOptions,java.lang.String)">initializeApp</a></code> must be used to create that relationship programmatically. The name parameter must be unique. To connect to the resources exposed by that project, use the <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> object returned by <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html#getInstance(java.lang.String)">getInstance</a></code>, passing it the same name used with <code>
- initializeApp</code>. This object must be passed to the static accessor of the feature that provides the resource. For example, <code><a href="/docs/reference/android/com/google/firebase/storage/FirebaseStorage.html#getInstance(com.google.firebase.FirebaseApp)">getInstance</a></code> is used to access the storage bucket provided by the additional project, whereas <code><a href="/docs/reference/android/com/google/firebase/storage/FirebaseStorage.html#getInstance()">getInstance</a></code> is used to access the default project. </p>
+ initializeApp</code>. This object must be passed to the static accessor of the feature that provides the resource. For example, getInstance is used to access the storage bucket provided by the additional project, whereas getInstance is used to access the default project. </p>
<p>Any <code>FirebaseApp</code> initialization must occur only in the main process of the app. Use of Firebase in processes other than the main process is not supported and will likely cause problems related to resource contention.</p>
<h2>Summary</h2>
<div class="devsite-table-wrapper"> --- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/FirebaseApp.html 2023-03-09 23:33:53.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/FirebaseApp.html 2023-03-09 23:28:11.000000000 +0000
@@ -15,7 +15,7 @@
<p>For a vast majority of apps, <code><a href="/docs/reference/kotlin/com/google/firebase/provider/FirebaseInitProvider.html">FirebaseInitProvider</a></code> will handle the initialization of Firebase for the default project that it's configured to work with, via the data contained in the app's <code>google-services.json</code> file. This <code>
ContentProvider</code> is merged into the app's manifest by default when building with Gradle, and it runs automatically at app launch. <b>No additional lines of code are needed in this case.</b></p>
<p>In the event that an app requires access to another Firebase project <b>in addition to</b> the default project, <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html#initializeApp(android.content.Context,com.google.firebase.FirebaseOptions,java.lang.String)">initializeApp</a></code> must be used to create that relationship programmatically. The name parameter must be unique. To connect to the resources exposed by that project, use the <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> object returned by <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html#getInstance(java.lang.String)">getInstance</a></code>, passing it the same name used with <code>
- initializeApp</code>. This object must be passed to the static accessor of the feature that provides the resource. For example, <code><a href="/docs/reference/kotlin/com/google/firebase/storage/FirebaseStorage.html#getInstance(com.google.firebase.FirebaseApp)">getInstance</a></code> is used to access the storage bucket provided by the additional project, whereas <code><a href="/docs/reference/kotlin/com/google/firebase/storage/FirebaseStorage.html#getInstance()">getInstance</a></code> is used to access the default project. </p>
+ initializeApp</code>. This object must be passed to the static accessor of the feature that provides the resource. For example, getInstance is used to access the storage bucket provided by the additional project, whereas getInstance is used to access the default project. </p>
<p>Any <code>FirebaseApp</code> initialization must occur only in the main process of the app. Use of Firebase in processes other than the main process is not supported and will likely cause problems related to resource contention.</p>
<h2>Summary</h2>
<div class="devsite-table-wrapper"> |
Generated by 🚫 Danger |
21cbe7a
to
021d33f
Compare
Coverage Report 1Affected ProductsNo changes between base commit (dfe71a9) and merge commit (3150a76).Test Logs |
Size Report 1Affected Products
Test Logs |
/retest |
rlazo
reviewed
Mar 9, 2023
firebase-appdistribution-api/firebase-appdistribution-api.gradle
Outdated
Show resolved
Hide resolved
firebase-installations-interop/firebase-installations-interop.gradle
Outdated
Show resolved
Hide resolved
LGTM, but I differ final approval to @rlazo |
rlazo
approved these changes
Mar 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.