Skip to content

Make more app distro deps static #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2023
Merged

Make more app distro deps static #4781

merged 2 commits into from
Mar 14, 2023

Conversation

lfkellogg
Copy link
Contributor

I think these were missed in #4697

@lfkellogg lfkellogg requested a review from davidmotson March 14, 2023 17:06
@lfkellogg lfkellogg marked this pull request as ready for review March 14, 2023 17:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 14, 2023 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (bff9326) and merge commit (f32eaf0).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gLTpINqimP.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023 •
edited
Loading

Unit Test Results

  34 files  +  28    34 suites  +28   1m 33s ⏱️ + 1m 15s
177 tests +159  177 ✔️ +159  0 💤 ±0  0 ❌ ±0 
354 runs  +318  354 ✔️ +318  0 💤 ±0  0 ❌ ±0 

Results for commit 9ea41a9. ± Comparison against base commit bff9326.

This pull request removes 18 and adds 177 tests. Note that renamed tests count towards both. 
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_emptyLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_isNotRedirectResponse_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_missingLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_onAppResume_setsUpdateCancelled
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenAabReleaseAvailable_redirectsToPlay
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenOpenConnectionFails_setsNetworkFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateApp_whenCalledMultipleTimesWithAAB_onlyMakesOneRequest
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ installActivityDestroyed_setsInstallError
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ installApk_currentActivityNotNull_InstallIntentOnCurrentActivity
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ whenCalledMultipleTimes_onlyEmitsOneIntent
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 14, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (bff9326)Merge (f32eaf0)Diff
    apk (aggressive)903 kB903 kB-4 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ShQgaosaxX.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 14, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-appdistribution

    DeviceStatisticsDistributions
    oriole-32
    Percentilebff9326f32eaf0DiffSignificant (?)
    p10952 ±877 μs1.06 ±0.7 ms+105 μs (+11.0%)NO
    p251.02 ±0.9 ms1.10 ±0.7 ms+80.4 μs (+7.9%)NO
    p501.11 ±1 ms1.18 ±0.8 ms+70.4 μs (+6.4%)NO
    p751.25 ±1 ms1.28 ±0.8 ms+37.4 μs (+3.0%)NO
    p901.45 ±1 ms1.55 ±0.9 ms+106 μs (+7.3%)NO

    20 test runs in comparison
    CommitTest Runs
    bff9326
    • 2023-03-14_17:11:05.570622_nXgB
    • 2023-03-14_17:11:05.573497_XQfJ
    • 2023-03-14_17:11:05.573510_esoI
    • 2023-03-14_17:11:05.573518_DMwq
    • 2023-03-14_17:11:05.573525_SUxC
    • 2023-03-14_17:11:05.573532_Dfqq
    • 2023-03-14_17:11:05.573538_Fymm
    • 2023-03-14_17:11:05.573545_GRrJ
    • 2023-03-14_17:11:05.573551_Oazl
    • 2023-03-14_17:11:05.573557_wErb
    f32eaf0
    • 2023-03-14_18:03:40.799297_eqFD
    • 2023-03-14_18:03:40.813108_FJXw
    • 2023-03-14_18:03:40.813129_OxTG
    • 2023-03-14_18:03:40.813138_SaOZ
    • 2023-03-14_18:03:40.813145_fTSv
    • 2023-03-14_18:03:40.813152_ekld
    • 2023-03-14_18:03:40.813160_jtIh
    • 2023-03-14_18:03:40.813329_TcXv
    • 2023-03-14_18:03:40.813338_Ztsc
    • 2023-03-14_18:03:40.813345_Ydnd
    redfin-30
    Percentilebff9326f32eaf0DiffSignificant (?)
    p102.45 ±2 ms2.10 ±2 ms-351 μs (-14.3%)NO
    p252.58 ±2 ms2.20 ±2 ms-388 μs (-15.0%)NO
    p502.76 ±2 ms2.35 ±2 ms-406 μs (-14.7%)NO
    p752.95 ±2 ms2.61 ±2 ms-345 μs (-11.7%)NO
    p903.54 ±3 ms3.24 ±3 ms-299 μs (-8.4%)NO

    20 test runs in comparison
    CommitTest Runs
    bff9326
    • 2023-03-14_17:11:05.570622_nXgB
    • 2023-03-14_17:11:05.573497_XQfJ
    • 2023-03-14_17:11:05.573510_esoI
    • 2023-03-14_17:11:05.573518_DMwq
    • 2023-03-14_17:11:05.573525_SUxC
    • 2023-03-14_17:11:05.573532_Dfqq
    • 2023-03-14_17:11:05.573538_Fymm
    • 2023-03-14_17:11:05.573545_GRrJ
    • 2023-03-14_17:11:05.573551_Oazl
    • 2023-03-14_17:11:05.573557_wErb
    f32eaf0
    • 2023-03-14_18:03:40.799297_eqFD
    • 2023-03-14_18:03:40.813108_FJXw
    • 2023-03-14_18:03:40.813129_OxTG
    • 2023-03-14_18:03:40.813138_SaOZ
    • 2023-03-14_18:03:40.813145_fTSv
    • 2023-03-14_18:03:40.813152_ekld
    • 2023-03-14_18:03:40.813160_jtIh
    • 2023-03-14_18:03:40.813329_TcXv
    • 2023-03-14_18:03:40.813338_Ztsc
    • 2023-03-14_18:03:40.813345_Ydnd

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilebff9326f32eaf0DiffSignificant (?)
    p10196 ±9 ms198 ±7 ms+2.40 ms (+1.2%)NO
    p25203 ±11 ms204 ±8 ms+718 μs (+0.4%)NO
    p50217 ±26 ms212 ±8 ms-4.90 ms (-2.3%)NO
    p75228 ±32 ms222 ±9 ms-6.38 ms (-2.8%)NO
    p90238 ±34 ms234 ±9.7 ms-3.96 ms (-1.7%)NO

    20 test runs in comparison
    CommitTest Runs
    bff9326
    • 2023-03-14_17:11:05.570622_nXgB
    • 2023-03-14_17:11:05.573497_XQfJ
    • 2023-03-14_17:11:05.573510_esoI
    • 2023-03-14_17:11:05.573518_DMwq
    • 2023-03-14_17:11:05.573525_SUxC
    • 2023-03-14_17:11:05.573532_Dfqq
    • 2023-03-14_17:11:05.573538_Fymm
    • 2023-03-14_17:11:05.573545_GRrJ
    • 2023-03-14_17:11:05.573551_Oazl
    • 2023-03-14_17:11:05.573557_wErb
    f32eaf0
    • 2023-03-14_18:03:40.799297_eqFD
    • 2023-03-14_18:03:40.813108_FJXw
    • 2023-03-14_18:03:40.813129_OxTG
    • 2023-03-14_18:03:40.813138_SaOZ
    • 2023-03-14_18:03:40.813145_fTSv
    • 2023-03-14_18:03:40.813152_ekld
    • 2023-03-14_18:03:40.813160_jtIh
    • 2023-03-14_18:03:40.813329_TcXv
    • 2023-03-14_18:03:40.813338_Ztsc
    • 2023-03-14_18:03:40.813345_Ydnd
    redfin-30
    Percentilebff9326f32eaf0DiffSignificant (?)
    p10231 ±4 ms256 ±11 ms+25.1 ms (+10.8%)NO
    p25237 ±4 ms263 ±13 ms+26.3 ms (+11.1%)NO
    p50244 ±6 ms272 ±15 ms+27.8 ms (+11.4%)NO
    p75254 ±8 ms283 ±16 ms+29.5 ms (+11.6%)NO
    p90264 ±9 ms297 ±17 ms+33.3 ms (+12.6%)NO

    20 test runs in comparison
    CommitTest Runs
    bff9326
    • 2023-03-14_17:11:05.570622_nXgB
    • 2023-03-14_17:11:05.573497_XQfJ
    • 2023-03-14_17:11:05.573510_esoI
    • 2023-03-14_17:11:05.573518_DMwq
    • 2023-03-14_17:11:05.573525_SUxC
    • 2023-03-14_17:11:05.573532_Dfqq
    • 2023-03-14_17:11:05.573538_Fymm
    • 2023-03-14_17:11:05.573545_GRrJ
    • 2023-03-14_17:11:05.573551_Oazl
    • 2023-03-14_17:11:05.573557_wErb
    f32eaf0
    • 2023-03-14_18:03:40.799297_eqFD
    • 2023-03-14_18:03:40.813108_FJXw
    • 2023-03-14_18:03:40.813129_OxTG
    • 2023-03-14_18:03:40.813138_SaOZ
    • 2023-03-14_18:03:40.813145_fTSv
    • 2023-03-14_18:03:40.813152_ekld
    • 2023-03-14_18:03:40.813160_jtIh
    • 2023-03-14_18:03:40.813329_TcXv
    • 2023-03-14_18:03:40.813338_Ztsc
    • 2023-03-14_18:03:40.813345_Ydnd

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1Wjn4zuP7u/index.html

@lfkellogg lfkellogg merged commit 0a73fdb into master Mar 14, 2023
@lfkellogg lfkellogg deleted the lk/static-deps branch March 14, 2023 20:45
@firebase firebase locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidmotson davidmotson davidmotson approved these changes

Assignees
No one assigned
Labels
main-merge-ack size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @davidmotson