Skip to content

Add JSON encoder for SessionEvents #4778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2023
Merged

Add JSON encoder for SessionEvents #4778

merged 3 commits into from
Mar 14, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Mar 13, 2023

Add JSON encoder for SessionEvents.

Also moved the logic to construct a Session Start event out of the data class, this is to make the data class cleaner and easier to read.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 13, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (1d6ab9d) to 26.42% (60d488b) by ?.

    FilenameBase (1d6ab9d)Merge (60d488b)Diff
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?72.00%?
    SessionGenerator.kt?0.00%?
    SessionInitiator.kt?0.00%?
    WallClock.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jjWFxFctSS.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023 •
edited
Loading

Unit Test Results

  8 files    8 suites   20s ⏱️
12 tests 12 ✔️ 0 💤 0 ❌
24 runs  24 ✔️ 0 💤 0 ❌

Results for commit bc877aa.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 13, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (1d6ab9d)Merge (60d488b)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-encoders-json

    TypeBase (1d6ab9d)Merge (60d488b)Diff
    aar?11.3 kB? (?)
    apk (aggressive)?24.0 kB? (?)
    apk (release)?596 kB? (?)

  • firebase-sessions

    TypeBase (1d6ab9d)Merge (60d488b)Diff
    aar?22.9 kB? (?)
    apk (aggressive)?137 kB? (?)
    apk (release)?1.66 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EeyZ9Rv5be.html

davidmotson
davidmotson approved these changes Mar 13, 2023
View reviewed changes
visumickey
visumickey reviewed Mar 13, 2023
View reviewed changes
@mrober mrober merged commit 8acde15 into firebase-sessions Mar 14, 2023
@mrober mrober deleted the sessions-event-json branch March 14, 2023 22:05
@firebase firebase locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey approved these changes

@davidmotson davidmotson davidmotson approved these changes

@samedson samedson Awaiting requested review from samedson

Assignees
No one assigned
Labels
no-changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrober @google-oss-bot @visumickey @davidmotson