Skip to content

Integrate with FirebaseInstallations. #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2023
Merged

Integrate with FirebaseInstallations. #4796

merged 3 commits into from
Mar 17, 2023

Conversation

visumickey
Copy link
Contributor

#no-changelog Integrate with Firebase Installations which will be used to receive FID and add it to the session events (Followup PR).

@visumickey visumickey requested a review from samedson March 16, 2023 21:56
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (5e2a760) to 24.56% (6a8155d) by ?.

    FilenameBase (5e2a760)Merge (6a8155d)Diff
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?72.00%?
    SessionGenerator.kt?0.00%?
    SessionInitiator.kt?0.00%?
    WallClock.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ruAw3w2lf5.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023 •
edited
Loading

Unit Test Results

  8 files    8 suites   19s ⏱️
13 tests 13 ✔️ 0 💤 0 ❌
26 runs  26 ✔️ 0 💤 0 ❌

Results for commit fff52c1.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (5e2a760)Merge (6a8155d)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-encoders-json

    TypeBase (5e2a760)Merge (6a8155d)Diff
    aar?11.3 kB? (?)
    apk (aggressive)?24.0 kB? (?)
    apk (release)?596 kB? (?)

  • firebase-sessions

    TypeBase (5e2a760)Merge (6a8155d)Diff
    aar?24.1 kB? (?)
    apk (aggressive)?155 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0WxrIKVPQE.html

@visumickey visumickey merged commit ac3d738 into firebase-sessions Mar 17, 2023
@visumickey visumickey deleted the firebase-sessions-installations-integration branch March 17, 2023 16:19
@firebase firebase locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samedson samedson samedson approved these changes

@mrober mrober mrober approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@visumickey @google-oss-bot @samedson @mrober