Skip to content

Integrate with FirebaseInstallations. #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Integrate with FirebaseInstallations. #4796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8162da5
Integrate with FirebaseInstallations.
visumickey Mar 16, 2023
7703f3a
Use the FID installation instance as a part of initialization.
visumickey Mar 16, 2023
fff52c1
Make the style gods happy!
visumickey Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions firebase-sessions/firebase-sessions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,13 @@ android {
dependencies {
implementation("com.google.firebase:firebase-encoders:17.0.0")
implementation(project(":encoders:firebase-encoders-json"))
implementation("com.google.firebase:firebase-installations-interop:17.1.0")
implementation("com.google.firebase:firebase-common-ktx:20.3.1")
implementation("com.google.firebase:firebase-components:17.1.0")
implementation(libs.androidx.annotation)

runtimeOnly("com.google.firebase:firebase-installations:17.1.3")

testImplementation(libs.androidx.test.junit)
testImplementation(libs.androidx.test.runner)
testImplementation(libs.junit)
Expand Down
5 changes: 4 additions & 1 deletion firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ import android.app.Application
import android.util.Log
import androidx.annotation.Discouraged
import com.google.firebase.FirebaseApp
import com.google.firebase.installations.FirebaseInstallationsApi
import com.google.firebase.ktx.Firebase
import com.google.firebase.ktx.app

class FirebaseSessions internal constructor(firebaseApp: FirebaseApp) {
class FirebaseSessions
internal constructor(firebaseApp: FirebaseApp, firebaseInstallations: FirebaseInstallationsApi) {
private val sessionGenerator = SessionGenerator(collectEvents = true)

init {
Expand All @@ -34,6 +36,7 @@ class FirebaseSessions internal constructor(firebaseApp: FirebaseApp) {
} else {
Log.w(TAG, "Failed to register lifecycle callbacks, unexpected context ${context.javaClass}.")
}
Log.i(TAG, "Firebase Installations ID: ${firebaseInstallations.id}")
}

@Discouraged(message = "This will be replaced with a real API.")
Expand Down
9 changes: 8 additions & 1 deletion firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessionsRegistrar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import com.google.firebase.FirebaseApp
import com.google.firebase.components.Component
import com.google.firebase.components.ComponentRegistrar
import com.google.firebase.components.Dependency
import com.google.firebase.installations.FirebaseInstallationsApi
import com.google.firebase.platforminfo.LibraryVersionComponent

/**
Expand All @@ -33,7 +34,13 @@ internal class FirebaseSessionsRegistrar : ComponentRegistrar {
Component.builder(FirebaseSessions::class.java)
.name(LIBRARY_NAME)
.add(Dependency.required(FirebaseApp::class.java))
.factory { container -> FirebaseSessions(container.get(FirebaseApp::class.java)) }
.add(Dependency.required(FirebaseInstallationsApi::class.java))
.factory { container ->
FirebaseSessions(
container.get(FirebaseApp::class.java),
container.get(FirebaseInstallationsApi::class.java)
)
}
.eagerInDefaultApp()
.build(),
LibraryVersionComponent.create(LIBRARY_NAME, BuildConfig.VERSION_NAME)
Expand Down