Change "user" to "tester" in app distro javadocs #4810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (1057863) and merge commit (1b16216).Test Logs |
Unit Test Results 36 files + 8 36 suites +8 1m 49s ⏱️ +25s Results for commit e2e14a7. ± Comparison against base commit 1057863. This pull request removes 276 and adds 191 tests. Note that renamed tests count towards both. |
Size Report 1Affected ProductsNo changes between base commit (1057863) and merge commit (1b16216).Test Logs |
Javadoc Changes:--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appdistribution/FirebaseAppDistribution.html 2023-03-22 13:16:21.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appdistribution/FirebaseAppDistribution.html 2023-03-22 13:11:07.000000000 +0000
@@ -186,7 +186,7 @@
<tr>
<td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/InterruptionLevel.html">InterruptionLevel</a> interruptionLevel</code></td>
<td>
- <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the user.</p>
+ <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the tester.</p>
</td>
</tr>
</tbody>
@@ -226,7 +226,7 @@
<tr>
<td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/InterruptionLevel.html">InterruptionLevel</a> interruptionLevel</code></td>
<td>
- <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the user.</p>
+ <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the tester.</p>
</td>
</tr>
</tbody>--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/FirebaseAppDistribution.html 2023-03-22 13:16:21.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/FirebaseAppDistribution.html 2023-03-22 13:11:07.000000000 +0000
@@ -186,7 +186,7 @@
<tr>
<td><code>interruptionLevel: <a href="/docs/reference/kotlin/com/google/firebase/appdistribution/InterruptionLevel.html">InterruptionLevel</a></code></td>
<td>
- <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the user.</p>
+ <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the tester.</p>
</td>
</tr>
</tbody>
@@ -226,7 +226,7 @@
<tr>
<td><code>interruptionLevel: <a href="/docs/reference/kotlin/com/google/firebase/appdistribution/InterruptionLevel.html">InterruptionLevel</a></code></td>
<td>
- <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the user.</p>
+ <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the tester.</p>
</td>
</tr>
</tbody> |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
kaibolay
approved these changes
Mar 22, 2023
lfkellogg
added a commit
that referenced
this pull request
Apr 3, 2023
lfkellogg
added a commit
that referenced
this pull request
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.