Skip to content

Merge fad/next into master to prepare for M130 release #4843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Conversation

lfkellogg
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Javadoc Changes:
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appdistribution/FirebaseAppDistribution.html	2023-04-03 16:59:34.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appdistribution/FirebaseAppDistribution.html	2023-04-03 16:52:50.000000000 +0000
@@ -186,7 +186,7 @@
               <tr>
                 <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/InterruptionLevel.html">InterruptionLevel</a>&nbsp;interruptionLevel</code></td>
                 <td>
-                  <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the user.</p>
+                  <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the tester.</p>
                 </td>
               </tr>
             </tbody>
@@ -226,7 +226,7 @@
               <tr>
                 <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/InterruptionLevel.html">InterruptionLevel</a>&nbsp;interruptionLevel</code></td>
                 <td>
-                  <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the user.</p>
+                  <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the tester.</p>
                 </td>
               </tr>
             </tbody>
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/FirebaseAppDistribution.html	2023-04-03 16:59:34.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/FirebaseAppDistribution.html	2023-04-03 16:52:50.000000000 +0000
@@ -186,7 +186,7 @@
               <tr>
                 <td><code>interruptionLevel:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appdistribution/InterruptionLevel.html">InterruptionLevel</a></code></td>
                 <td>
-                  <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the user.</p>
+                  <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the tester.</p>
                 </td>
               </tr>
             </tbody>
@@ -226,7 +226,7 @@
               <tr>
                 <td><code>interruptionLevel:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appdistribution/InterruptionLevel.html">InterruptionLevel</a></code></td>
                 <td>
-                  <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the user.</p>
+                  <p>the level of interruption for the feedback notification. On platforms below Android 8, this corresponds to a <a href="https://developer.android.com/develop/ui/views/notifications/channels#importance">notification channel importance</a> and once set cannot be changed except by the tester.</p>
                 </td>
               </tr>
             </tbody>

@kaibolay kaibolay enabled auto-merge (squash) April 3, 2023 16:50
@kaibolay kaibolay disabled auto-merge April 3, 2023 16:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Unit Test Results

  36 files   -    738    36 suites   - 738   1m 52s ⏱️ - 31m 38s
191 tests  - 4 662  191 ✔️  - 4 641  0 💤  - 21  0 ±0 
382 runs   - 9 121  382 ✔️  - 9 079  0 💤  - 42  0 ±0 

Results for commit e3d0ed5. ± Comparison against base commit b68c1f6.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (b68c1f6)Merge (2d15a20)Diff
    aar245 kB247 kB+2.60 kB (+1.1%)
    apk (aggressive)904 kB905 kB+1.13 kB (+0.1%)
    apk (release)2.64 MB2.64 MB+2.63 kB (+0.1%)
  • firebase-appdistribution-api

    TypeBase (b68c1f6)Merge (2d15a20)Diff
    apk (release)1.27 MB1.27 MB-4 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/emPWhZGvlx.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-appdistribution

    DeviceStatisticsDistributions
    oriole-32
    Percentileb68c1f62d15a20DiffSignificant (?)
    p10744 ±781 μs762 ±691 μs+17.8 μs (+2.4%)NO
    p25778 ±818 μs786 ±712 μs+8.62 μs (+1.1%)NO
    p50868 ±909 μs836 ±733 μs-31.9 μs (-3.7%)NO
    p75998 ±999 μs939 ±778 μs-58.8 μs (-5.9%)NO
    p901.20 ±1 ms1.26 ±0.8 ms+66.1 μs (+5.5%)NO

    20 test runs in comparison
    CommitTest Runs
    b68c1f6
    • 2023-03-31_18:02:27.817560_QdxD
    • 2023-03-31_18:02:27.824440_RGSH
    • 2023-03-31_18:02:27.824462_gQSV
    • 2023-03-31_18:02:27.824468_Utlb
    • 2023-03-31_18:02:27.824475_VoHT
    • 2023-03-31_18:02:27.824480_mlCO
    • 2023-03-31_18:02:27.824486_AWDd
    • 2023-03-31_18:02:27.824491_UGfJ
    • 2023-03-31_18:02:27.824496_aEgs
    • 2023-03-31_18:02:27.824502_fIQv
    2d15a20
    • 2023-04-03_17:01:31.369147_sDHn
    • 2023-04-03_17:01:31.374358_kNZi
    • 2023-04-03_17:01:31.374370_TqFj
    • 2023-04-03_17:01:31.374376_mfEN
    • 2023-04-03_17:01:31.374381_YzAx
    • 2023-04-03_17:01:31.374558_ctbS
    • 2023-04-03_17:01:31.374565_hhxJ
    • 2023-04-03_17:01:31.374570_CAsY
    • 2023-04-03_17:01:31.374575_VRsh
    • 2023-04-03_17:01:31.374581_lvGy
    redfin-30
    Percentileb68c1f62d15a20DiffSignificant (?)
    p101.87 ±2 ms1.77 ±2 ms-98.1 μs (-5.3%)NO
    p251.94 ±2 ms2.11 ±2 ms+170 μs (+8.8%)NO
    p502.07 ±2 ms2.39 ±2 ms+323 μs (+15.6%)NO
    p752.23 ±2 ms2.77 ±3 ms+539 μs (+24.1%)NO
    p902.45 ±3 ms3.42 ±3 ms+970 μs (+39.6%)NO

    20 test runs in comparison
    CommitTest Runs
    b68c1f6
    • 2023-03-31_18:02:27.817560_QdxD
    • 2023-03-31_18:02:27.824440_RGSH
    • 2023-03-31_18:02:27.824462_gQSV
    • 2023-03-31_18:02:27.824468_Utlb
    • 2023-03-31_18:02:27.824475_VoHT
    • 2023-03-31_18:02:27.824480_mlCO
    • 2023-03-31_18:02:27.824486_AWDd
    • 2023-03-31_18:02:27.824491_UGfJ
    • 2023-03-31_18:02:27.824496_aEgs
    • 2023-03-31_18:02:27.824502_fIQv
    2d15a20
    • 2023-04-03_17:01:31.369147_sDHn
    • 2023-04-03_17:01:31.374358_kNZi
    • 2023-04-03_17:01:31.374370_TqFj
    • 2023-04-03_17:01:31.374376_mfEN
    • 2023-04-03_17:01:31.374381_YzAx
    • 2023-04-03_17:01:31.374558_ctbS
    • 2023-04-03_17:01:31.374565_hhxJ
    • 2023-04-03_17:01:31.374570_CAsY
    • 2023-04-03_17:01:31.374575_VRsh
    • 2023-04-03_17:01:31.374581_lvGy
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileb68c1f62d15a20DiffSignificant (?)
    p10193 ±9 ms195 ±2 ms+1.75 ms (+0.9%)NO
    p25201 ±10 ms201 ±2 ms+96.2 μs (+0.0%)NO
    p50211 ±18 ms209 ±3 ms-2.60 ms (-1.2%)NO
    p75224 ±29 ms218 ±3 ms-6.39 ms (-2.8%)NO
    p90234 ±32 ms235 ±10 ms+1.06 ms (+0.5%)NO

    20 test runs in comparison
    CommitTest Runs
    b68c1f6
    • 2023-03-31_18:02:27.817560_QdxD
    • 2023-03-31_18:02:27.824440_RGSH
    • 2023-03-31_18:02:27.824462_gQSV
    • 2023-03-31_18:02:27.824468_Utlb
    • 2023-03-31_18:02:27.824475_VoHT
    • 2023-03-31_18:02:27.824480_mlCO
    • 2023-03-31_18:02:27.824486_AWDd
    • 2023-03-31_18:02:27.824491_UGfJ
    • 2023-03-31_18:02:27.824496_aEgs
    • 2023-03-31_18:02:27.824502_fIQv
    2d15a20
    • 2023-04-03_17:01:31.369147_sDHn
    • 2023-04-03_17:01:31.374358_kNZi
    • 2023-04-03_17:01:31.374370_TqFj
    • 2023-04-03_17:01:31.374376_mfEN
    • 2023-04-03_17:01:31.374381_YzAx
    • 2023-04-03_17:01:31.374558_ctbS
    • 2023-04-03_17:01:31.374565_hhxJ
    • 2023-04-03_17:01:31.374570_CAsY
    • 2023-04-03_17:01:31.374575_VRsh
    • 2023-04-03_17:01:31.374581_lvGy
    redfin-30
    Percentileb68c1f62d15a20DiffSignificant (?)
    p10231 ±5 ms253 ±4 ms+22.7 ms (+9.8%)MAYBE
    p25237 ±5 ms259 ±4 ms+22.8 ms (+9.6%)MAYBE
    p50244 ±6 ms267 ±4 ms+23.0 ms (+9.4%)MAYBE
    p75251 ±6 ms276 ±4 ms+25.3 ms (+10.1%)MAYBE
    p90261 ±9 ms290 ±7 ms+28.3 ms (+10.8%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    b68c1f6
    • 2023-03-31_18:02:27.817560_QdxD
    • 2023-03-31_18:02:27.824440_RGSH
    • 2023-03-31_18:02:27.824462_gQSV
    • 2023-03-31_18:02:27.824468_Utlb
    • 2023-03-31_18:02:27.824475_VoHT
    • 2023-03-31_18:02:27.824480_mlCO
    • 2023-03-31_18:02:27.824486_AWDd
    • 2023-03-31_18:02:27.824491_UGfJ
    • 2023-03-31_18:02:27.824496_aEgs
    • 2023-03-31_18:02:27.824502_fIQv
    2d15a20
    • 2023-04-03_17:01:31.369147_sDHn
    • 2023-04-03_17:01:31.374358_kNZi
    • 2023-04-03_17:01:31.374370_TqFj
    • 2023-04-03_17:01:31.374376_mfEN
    • 2023-04-03_17:01:31.374381_YzAx
    • 2023-04-03_17:01:31.374558_ctbS
    • 2023-04-03_17:01:31.374565_hhxJ
    • 2023-04-03_17:01:31.374570_CAsY
    • 2023-04-03_17:01:31.374575_VRsh
    • 2023-04-03_17:01:31.374581_lvGy

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vrvmzhjxuS/index.html

@lfkellogg lfkellogg merged commit 7f7eb95 into master Apr 3, 2023
@lfkellogg lfkellogg deleted the fad/next branch April 3, 2023 18:45
@firebase firebase locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants