Skip to content

Package session start event's application information. #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 31, 2023
Merged

Package session start event's application information. #4829

merged 6 commits into from
Mar 31, 2023

Conversation

visumickey
Copy link
Contributor

@visumickey visumickey commented Mar 28, 2023 •
edited
Loading

#no-changelog

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 28, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (09d35f6) to 48.17% (792cc41) by ?.

    FilenameBase (09d35f6)Merge (792cc41)Diff
    ApplicationInfo.kt?100.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    SessionCoordinator.kt?83.33%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?100.00%?
    SessionGenerator.kt?22.73%?
    SessionInitiator.kt?0.00%?
    WallClock.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gu0cO7rtjd.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023 •
edited
Loading

Unit Test Results

12 files  12 suites   25s ⏱️
15 tests 15 ✔️ 0 💤 0 ❌
30 runs  30 ✔️ 0 💤 0 ❌

Results for commit c664692.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 28, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (09d35f6)Merge (792cc41)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-encoders-json

    TypeBase (09d35f6)Merge (792cc41)Diff
    aar?11.3 kB? (?)
    apk (aggressive)?24.0 kB? (?)
    apk (release)?596 kB? (?)

  • firebase-sessions

    TypeBase (09d35f6)Merge (792cc41)Diff
    aar?34.9 kB? (?)
    apk (aggressive)?203 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IjE5kgXy6q.html

@visumickey visumickey changed the title [Draft] Package session start event's application information. Package session start event's application information. Mar 29, 2023
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@visumickey visumickey marked this pull request as ready for review March 29, 2023 20:37
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]
error: Added method com.google.firebase.sessions.FirebaseSessions.getFirebaseApp() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

samedson
samedson approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mrober
mrober reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@mrober mrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple comments

mrober
mrober approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@mrober mrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple comments

@visumickey visumickey merged commit c8e6b4c into firebase-sessions Mar 31, 2023
@visumickey visumickey deleted the firebase-sessions-eventdata branch March 31, 2023 01:34
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@firebase firebase locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samedson samedson samedson approved these changes

@mrober mrober mrober approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
no-changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@visumickey @google-oss-bot @samedson @mrober