-
Notifications
You must be signed in to change notification settings - Fork 625
Package session start event's application information. #4829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a87b4b1
[Draft] Package session start event's application information.
visumickey b759057
Update the unit tests to make the application info validation.
visumickey 7c793c8
Add copyright information.
visumickey 5918621
Keep the style gods happy.
visumickey c664692
Use Kotlin style to initialize with the constructor.
visumickey 7127e6b
Address comments.
visumickey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
74 changes: 74 additions & 0 deletions
74
firebase-sessions/src/main/kotlin/com/google/firebase/sessions/ApplicationInfo.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
/* | ||
* Copyright 2023 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.firebase.sessions | ||
|
||
import com.google.firebase.FirebaseApp | ||
import com.google.firebase.encoders.json.NumberedEnum | ||
|
||
/** Enum denoting different development environments. */ | ||
internal enum class LogEnvironment(override val number: Int) : NumberedEnum { | ||
/** Unknown environment. */ | ||
LOG_ENVIRONMENT_UNKNOWN(0), | ||
|
||
/** Autopush environment. */ | ||
LOG_ENVIRONMENT_AUTOPUSH(1), | ||
|
||
/** Staging environment. */ | ||
LOG_ENVIRONMENT_STAGING(2), | ||
|
||
/** Production environment. */ | ||
LOG_ENVIRONMENT_PROD(3), | ||
} | ||
|
||
internal data class AndroidApplicationInfo( | ||
/** The package name of the application/bundle name. */ | ||
val packageName: String, | ||
|
||
/** The version of the application. */ | ||
val versionName: String, | ||
) | ||
|
||
internal data class ApplicationInfo( | ||
/** The Firebase Application ID of the application. */ | ||
val appId: String, | ||
|
||
/** The model of the device that runs the application. */ | ||
val deviceModel: String, | ||
|
||
/** The SDK version of the sessions library. */ | ||
val sessionSdkVersion: String, | ||
|
||
/** The logging environment for the events. */ | ||
val logEnvironment: LogEnvironment, | ||
|
||
/** The android application information for the app. */ | ||
val androidAppInfo: AndroidApplicationInfo, | ||
) | ||
|
||
internal fun getApplicationInfo(firebaseApp: FirebaseApp): ApplicationInfo { | ||
val packageName = firebaseApp.applicationContext.packageName | ||
val packageInfo = firebaseApp.applicationContext.packageManager.getPackageInfo(packageName, 0) | ||
|
||
return ApplicationInfo( | ||
appId = firebaseApp.options.applicationId, | ||
deviceModel = "", | ||
sessionSdkVersion = BuildConfig.VERSION_NAME, | ||
logEnvironment = LogEnvironment.LOG_ENVIRONMENT_PROD, | ||
androidAppInfo = | ||
AndroidApplicationInfo(packageName = packageName, versionName = packageInfo.versionName) | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
firebase-sessions/src/test/kotlin/com/google/firebase/sessions/ApplicationInfoTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Copyright 2023 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.firebase.sessions | ||
|
||
import android.content.Context | ||
import androidx.test.core.app.ApplicationProvider | ||
import com.google.common.truth.Truth.assertThat | ||
import com.google.firebase.FirebaseApp | ||
import com.google.firebase.sessions.testing.FakeFirebaseApp | ||
import org.junit.After | ||
import org.junit.Test | ||
import org.junit.runner.RunWith | ||
import org.robolectric.RobolectricTestRunner | ||
|
||
@RunWith(RobolectricTestRunner::class) | ||
class ApplicationInfoTest { | ||
|
||
@Test | ||
fun applicationInfo_populatesInfoCorrectly() { | ||
val applicationInfo = getApplicationInfo(FakeFirebaseApp.fakeFirebaseApp()) | ||
assertThat(applicationInfo) | ||
.isEqualTo( | ||
ApplicationInfo( | ||
appId = FakeFirebaseApp.MOCK_APP_ID, | ||
deviceModel = "", | ||
sessionSdkVersion = BuildConfig.VERSION_NAME, | ||
logEnvironment = LogEnvironment.LOG_ENVIRONMENT_PROD, | ||
AndroidApplicationInfo( | ||
packageName = ApplicationProvider.getApplicationContext<Context>().packageName, | ||
versionName = FakeFirebaseApp.MOCK_APP_VERSION | ||
) | ||
) | ||
) | ||
} | ||
|
||
@After | ||
fun cleanUp() { | ||
FirebaseApp.clearInstancesForTest() | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
firebase-sessions/src/test/kotlin/com/google/firebase/sessions/testing/FakeFirebaseApp.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Copyright 2023 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.firebase.sessions.testing | ||
|
||
import android.content.Context | ||
import androidx.test.core.app.ApplicationProvider | ||
import androidx.test.core.content.pm.PackageInfoBuilder | ||
import com.google.firebase.FirebaseApp | ||
import com.google.firebase.FirebaseOptions | ||
import com.google.firebase.ktx.Firebase | ||
import com.google.firebase.ktx.initialize | ||
import org.robolectric.Shadows | ||
|
||
object FakeFirebaseApp { | ||
internal val MOCK_PROJECT_ID = "project" | ||
internal val MOCK_APP_ID = "1:12345:android:app" | ||
internal val MOCK_API_KEY = "RANDOM_APIKEY_FOR_TESTING" | ||
internal val MOCK_APP_VERSION = "1.0.0" | ||
|
||
fun fakeFirebaseApp(): FirebaseApp { | ||
val shadowPackageManager = | ||
Shadows.shadowOf(ApplicationProvider.getApplicationContext<Context>().packageManager) | ||
val packageInfo = | ||
PackageInfoBuilder.newBuilder() | ||
.setPackageName(ApplicationProvider.getApplicationContext<Context>().packageName) | ||
.build() | ||
packageInfo.versionName = MOCK_APP_VERSION | ||
shadowPackageManager.installPackage(packageInfo) | ||
|
||
val firebaseApp = | ||
Firebase.initialize( | ||
ApplicationProvider.getApplicationContext(), | ||
FirebaseOptions.Builder() | ||
.setApplicationId(MOCK_APP_ID) | ||
.setApiKey(MOCK_API_KEY) | ||
.setProjectId(MOCK_PROJECT_ID) | ||
.build() | ||
) | ||
return firebaseApp | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.