Skip to content

Integrate firebase-sessions with GoogleDataTransport #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2023
Merged

Integrate firebase-sessions with GoogleDataTransport #4851

merged 1 commit into from
Apr 6, 2023

Conversation

samedson
Copy link
Contributor

@samedson samedson commented Apr 4, 2023 •
edited
Loading

  • Adds a dependency on data-transport
  • Adds TestSessionEventData.kt to store Session Event objects used for testing

#no-changelog

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 4, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (e7050b3) to 46.70% (ff5f3fa) by ?.

    12 individual files with coverage change

    FilenameBase (e7050b3)Merge (ff5f3fa)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?90.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?100.00%?
    SessionGenerator.kt?22.73%?
    SessionInitiator.kt?0.00%?
    SessionsSettings.kt?0.00%?
    WallClock.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xV8SWucvOJ.html

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023 •
edited
Loading

Unit Test Results

16 files  16 suites   19s ⏱️
17 tests 17 ✔️ 0 💤 0 ❌
34 runs  34 ✔️ 0 💤 0 ❌

Results for commit 34c44fc.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 4, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (e7050b3)Merge (ff5f3fa)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (e7050b3)Merge (ff5f3fa)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (e7050b3)Merge (ff5f3fa)Diff
    aar?39.4 kB? (?)
    apk (aggressive)?250 kB? (?)
    apk (release)?1.77 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dB3ZC37uyj.html

samedson
samedson commented Apr 4, 2023
View reviewed changes
@firebase firebase deleted a comment from google-oss-bot Apr 4, 2023
@samedson samedson requested review from mrober and visumickey April 4, 2023 20:16
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@firebase firebase deleted a comment from google-oss-bot Apr 5, 2023
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

samedson
samedson commented Apr 5, 2023
View reviewed changes
firebase-sessions/firebase-sessions.gradle.kts
implementation(libs.androidx.annotation)

runtimeOnly("com.google.firebase:firebase-installations:17.1.3")
runtimeOnly(project(":firebase-datatransport"))
Copy link
Contributor Author

@samedson samedson Apr 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was required to make FireLog work

Before I had implementation("com.google.android.datatransport:transport-backend-cct:3.1.8")

@samedson samedson force-pushed the gdt branch 2 times, most recently from 75aa84a to 3beb945 Compare April 5, 2023 20:45
@samedson samedson merged commit 889d2ac into firebase-sessions Apr 6, 2023
@samedson samedson deleted the gdt branch April 6, 2023 14:36
@firebase firebase locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

@visumickey visumickey Awaiting requested review from visumickey

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samedson @google-oss-bot @visumickey @mrober