-
Notifications
You must be signed in to change notification settings - Fork 624
Integrate firebase-sessions with GoogleDataTransport #4851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
firebase-sessions/src/main/kotlin/com/google/firebase/sessions/EventGDTLogger.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* | ||
* Copyright 2023 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.firebase.sessions | ||
|
||
import com.google.android.datatransport.* | ||
import com.google.android.datatransport.TransportFactory | ||
import com.google.firebase.inject.Provider | ||
|
||
/** | ||
* The [EventGDTLoggerInterface] is for testing purposes so that we can mock EventGDTLogger in other | ||
* classes that depend on it. | ||
* | ||
* @hide | ||
*/ | ||
internal interface EventGDTLoggerInterface { | ||
fun log(sessionEvent: SessionEvent) | ||
} | ||
|
||
/** | ||
* The [EventGDTLogger] is responsible for encoding and logging events to the Google Data Transport | ||
* library. | ||
* | ||
* @hide | ||
*/ | ||
internal class EventGDTLogger(private val transportFactoryProvider: Provider<TransportFactory>) : | ||
EventGDTLoggerInterface { | ||
|
||
// Logs a [SessionEvent] to FireLog | ||
override fun log(sessionEvent: SessionEvent) { | ||
transportFactoryProvider | ||
.get() | ||
.getTransport( | ||
EventGDTLogger.AQS_LOG_SOURCE, | ||
SessionEvent::class.java, | ||
Encoding.of("json"), | ||
this::encode, | ||
) | ||
.send(Event.ofData(sessionEvent)) | ||
} | ||
|
||
private fun encode(value: SessionEvent): ByteArray { | ||
return SessionEvents.SESSION_EVENT_ENCODER.encode(value).toByteArray() | ||
} | ||
|
||
companion object { | ||
// TODO What do we put for the AQS Log Source | ||
private const val AQS_LOG_SOURCE = "FIREBASE_APPQUALITY_SESSION" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessionsEarly.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Copyright 2023 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.firebase.sessions | ||
|
||
/** | ||
* The Firebase Sessions early initialization. | ||
* | ||
* @hide | ||
* | ||
* TODO: This should handle generating the Session ID and communicating with subscribers. | ||
*/ | ||
class FirebaseSessionsEarly {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
firebase-sessions/src/test/kotlin/com/google/firebase/sessions/EventGDTLoggerTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* | ||
* Copyright 2023 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.firebase.sessions | ||
|
||
import com.google.android.datatransport.Encoding | ||
import com.google.android.datatransport.Event | ||
import com.google.android.datatransport.TransportFactory | ||
import com.google.common.truth.Truth.assertThat | ||
import com.google.firebase.FirebaseApp | ||
import com.google.firebase.sessions.testing.FakeFirebaseApp | ||
import com.google.firebase.sessions.testing.FakeProvider | ||
import com.google.firebase.sessions.testing.FakeTransportFactory | ||
import com.google.firebase.sessions.testing.TestSessionEventData | ||
import org.junit.After | ||
import org.junit.Test | ||
import org.junit.runner.RunWith | ||
import org.robolectric.RobolectricTestRunner | ||
|
||
@RunWith(RobolectricTestRunner::class) | ||
class EventGDTLoggerTest { | ||
|
||
@Test | ||
fun event_logsToGoogleDataTransport() { | ||
val sessionEvent = | ||
SessionEvents.startSession( | ||
FakeFirebaseApp.fakeFirebaseApp(), | ||
TestSessionEventData.TEST_SESSION_DETAILS | ||
) | ||
val fakeTransportFactory = FakeTransportFactory() | ||
val fakeTransportFactoryProvider = FakeProvider(fakeTransportFactory as TransportFactory) | ||
val eventGDTLogger = EventGDTLogger(transportFactoryProvider = fakeTransportFactoryProvider) | ||
|
||
eventGDTLogger.log(sessionEvent = sessionEvent) | ||
|
||
assertThat(fakeTransportFactory.name).isEqualTo("FIREBASE_APPQUALITY_SESSION") | ||
assertThat(fakeTransportFactory.payloadEncoding).isEqualTo(Encoding.of("json")) | ||
assertThat(fakeTransportFactory.fakeTransport!!.sentEvent) | ||
.isEqualTo(Event.ofData(TestSessionEventData.EXPECTED_DEFAULT_SESSION_EVENT)) | ||
} | ||
|
||
@After | ||
fun cleanUp() { | ||
FirebaseApp.clearInstancesForTest() | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
firebase-sessions/src/test/kotlin/com/google/firebase/sessions/testing/FakeEventGDTLogger.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* | ||
* Copyright 2023 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.firebase.sessions.testing | ||
|
||
import com.google.firebase.sessions.EventGDTLogger | ||
import com.google.firebase.sessions.EventGDTLoggerInterface | ||
import com.google.firebase.sessions.SessionEvent | ||
|
||
/** | ||
* The [FakeEventGDTLogger] is for mocking [EventGDTLogger]. | ||
* | ||
* @hide | ||
*/ | ||
internal class FakeEventGDTLogger : EventGDTLoggerInterface { | ||
|
||
// Lets tests assert the right event was logged. | ||
var loggedEvent: SessionEvent? = null | ||
|
||
override fun log(sessionEvent: SessionEvent) { | ||
loggedEvent = sessionEvent | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was required to make FireLog work
Before I had
implementation("com.google.android.datatransport:transport-backend-cct:3.1.8")