Skip to content

Setup configuration layer for the library. #4853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 5, 2023
Merged

Setup configuration layer for the library. #4853

merged 6 commits into from
Apr 5, 2023

Conversation

visumickey
Copy link
Contributor

No description provided.

@visumickey visumickey requested a review from mrober April 5, 2023 01:28
@visumickey visumickey requested a review from samedson April 5, 2023 01:28
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (69de793) to 47.06% (29f36be) by ?.

    FilenameBase (69de793)Merge (29f36be)Diff
    ApplicationInfo.kt?100.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    SessionCoordinator.kt?83.33%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?100.00%?
    SessionGenerator.kt?22.73%?
    SessionInitiator.kt?0.00%?
    SessionsSettings.kt?0.00%?
    WallClock.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OnfjztRqc4.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023 •
edited
Loading

Unit Test Results

14 files  14 suites   25s ⏱️
16 tests 16 ✔️ 0 💤 0 ❌
32 runs  32 ✔️ 0 💤 0 ❌

Results for commit 7e097dd.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.ApplicationInfoKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (69de793)Merge (29f36be)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-sessions

    TypeBase (69de793)Merge (29f36be)Diff
    aar?35.1 kB? (?)
    apk (aggressive)?203 kB? (?)
    apk (release)?1.69 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zneS1X8Lno.html

@visumickey visumickey merged commit 9300b74 into firebase-sessions Apr 5, 2023
@visumickey visumickey deleted the firebase-sessions-config-setup branch April 5, 2023 17:51
@firebase firebase locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

@samedson samedson samedson approved these changes

Assignees
No one assigned
Labels
api: sessions no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@visumickey @google-oss-bot @samedson @mrober