Skip to content

Improve CheckHeadDependencies check #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Improve CheckHeadDependencies check #4863

merged 3 commits into from
Apr 6, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 6, 2023

Error now includes the sdk that's pulling the dependency.

For example:

> Project-level dependency errors found. Please update the release config.
  firebase-firestore requires: protolite-well-known-types

Additionally, it now supports filtering dependencies.

Error now includes the sdk that's pulling the dependency.
@rlazo rlazo requested review from VinayGuthal and daymxn and removed request for VinayGuthal April 6, 2023 06:21
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

buildSrc Test Results

28 tests   28 ✔️  1m 15s ⏱️
  5 suites    0 💤
  5 files      0

Results for commit 40c9fb8.

♻️ This comment has been updated with latest results.

@rlazo rlazo changed the title Improve CheckHeadDependencies error reporting. Improve CheckHeadDependencies check Apr 6, 2023
@rlazo rlazo requested a review from davidmotson April 6, 2023 06:34
@rlazo
Copy link
Collaborator Author

rlazo commented Apr 6, 2023

@davidmotson please confirm that ignoring proto-well-known-types is OK. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Unit Test Results

   788 files  +   753     788 suites  +753   35m 49s ⏱️ + 31m 35s
4 853 tests +4 361  4 832 ✔️ +4 341  21 💤 +21  0  - 1 
9 615 runs  +9 102  9 573 ✔️ +9 061  42 💤 +42  0  - 1 

Results for commit 40c9fb8. ± Comparison against base commit 77b2f26.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 6, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 6, 2023

Startup Time Report 1

The report is too large (117,087 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0iCUqpzHv2/index.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

This report is too large (208,335 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RGuAV64m0i.html

@rlazo rlazo merged commit ca6216e into master Apr 6, 2023
@rlazo rlazo deleted the rl.checkhead999 branch April 6, 2023 18:51
@firebase firebase locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants