Fill in device_model field for AQS #4892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs |
mrober
reviewed
Apr 13, 2023
| @@ -45,7 +45,7 @@ internal object TestSessionEventData { | |||
| applicationInfo = | |||
| ApplicationInfo( | |||
| appId = FakeFirebaseApp.MOCK_APP_ID, | |||
| deviceModel = "", | |||
There was a problem hiding this comment.
Do the tests have access to Build.MODEL too?
There was a problem hiding this comment.
Seems they do - updated
mrober
reviewed
Apr 13, 2023
There was a problem hiding this comment.
Did some funny formatting happen to this file? Also I think Google style is to avoid the .* imports, and I don't see what class you needed from the import.
There was a problem hiding this comment.
Yeah the formatter did a weird one on this
mrober
approved these changes
Apr 13, 2023
Size Report 1Affected Products
Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume this needs to be consistent with the Crashlytics Device Model: https://github.com/firebase/firebase-android-sdk/blob/master/firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsReportDataCapture.java#L220