Skip to content

Fix some gradle deprecation warnings #4895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2023
Merged

Fix some gradle deprecation warnings #4895

merged 3 commits into from
Apr 15, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 14, 2023

No description provided.

@rlazo rlazo requested review from davidmotson and daymxn April 14, 2023 06:14
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

buildSrc Test Results

28 tests   28 ✔️  1m 28s ⏱️
  5 suites    0 💤
  5 files      0

Results for commit 8e04bfa.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

Unit Test Results

   788 files  +   630     788 suites  +630   35m 44s ⏱️ + 33m 55s
4 864 tests +3 741  4 843 ✔️ +3 736  21 💤 +  5  0 ±0 
9 637 runs  +7 391  9 595 ✔️ +7 381  42 💤 +10  0 ±0 

Results for commit 8e04bfa. ± Comparison against base commit f314ff7.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.13% (f314ff7) to 50.18% (18eb6a1) by +0.04%.

    FilenameBase (f314ff7)Merge (18eb6a1)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
  • firebase-firestore

    FilenameBase (f314ff7)Merge (18eb6a1)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GjeaNmQxFg.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2023

Startup Time Report 1

The report is too large (117,107 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RqUZPCdflp/index.html

Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff!

@rlazo rlazo merged commit 734adc0 into master Apr 15, 2023
@rlazo rlazo deleted the rl.deprec2101 branch April 15, 2023 11:31
@firebase firebase locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants