Skip to content

Fix some gradle deprecation warnings #4895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2023
Merged

Fix some gradle deprecation warnings #4895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9052da3
Fix some gradle deprecation warnings
rlazo Apr 14, 2023
d7eca24
Merge branch 'master' into rl.deprec2101
rlazo Apr 14, 2023
8e04bfa
Merge branch 'master' into rl.deprec2101
rlazo Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ buildscript {
}

dependencies {
classpath 'com.google.protobuf:protobuf-gradle-plugin:0.8.14'
classpath 'com.google.protobuf:protobuf-gradle-plugin:0.9.2'
classpath 'net.ltgt.gradle:gradle-errorprone-plugin:1.3.0'
classpath 'gradle.plugin.com.github.sherter.google-java-format:google-java-format-gradle-plugin:0.9'
classpath 'com.google.gms:google-services:4.3.15'
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/java/com/google/firebase/gradle/plugins/ci/Coverage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public static void apply(FirebaseLibraryExtension firebaseLibrary) {
JacocoPluginExtension jacoco = project.getExtensions().getByType(JacocoPluginExtension.class);

jacoco.setToolVersion("0.8.8");
jacoco.setReportsDir(reportsDir);
jacoco.getReportsDirectory().set(reportsDir);
project
.getTasks()
.withType(
Expand Down
4 changes: 2 additions & 2 deletions buildSrc/src/main/java/com/google/firebase/gradle/plugins/license/GenerateLicensesTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import org.gradle.api.tasks.Input;
import org.gradle.api.tasks.OutputDirectory;
import org.gradle.api.tasks.TaskAction;
import org.gradle.api.tasks.incremental.IncrementalTaskInputs;
import org.gradle.work.InputChanges;

abstract class GenerateLicensesTask extends DefaultTask {
private static final int NEW_LINE_LENGTH = "\n".getBytes().length;
Expand All @@ -56,7 +56,7 @@ public GenerateLicensesTask() {
}

@TaskAction
void execute(IncrementalTaskInputs inputs) {
void execute(InputChanges inputs) {
Set<URI> licenseUris = new HashSet<URI>();
for (ThirdPartyLicensesExtension.CustomLicense license : getadditionalLicenses()) {
licenseUris.addAll(license.licenseUris);
Expand Down