Skip to content

Implement sampling #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 20, 2023
Merged

Implement sampling #4896

merged 6 commits into from
Apr 20, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Apr 14, 2023

No description provided.

@mrober mrober requested review from samedson and visumickey April 14, 2023 16:25
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (b0bea40) to 64.39% (73aed99) by ?.

    14 individual files with coverage change

    FilenameBase (b0bea40)Merge (73aed99)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?90.00%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?100.00%?
    SessionGenerator.kt?20.00%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?84.62%?
    SettingsProvider.kt?0.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/taodlMx7rd.html

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023 •
edited
Loading

Unit Test Results

18 files  18 suites   33s ⏱️
23 tests 23 ✔️ 0 💤 0 ❌
46 runs  46 ✔️ 0 💤 0 ❌

Results for commit 80b3366.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (b0bea40)Merge (73aed99)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (b0bea40)Merge (73aed99)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (b0bea40)Merge (73aed99)Diff
    aar?48.3 kB? (?)
    apk (aggressive)?251 kB? (?)
    apk (release)?1.77 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cYm30Y4yDW.html

@mrober mrober requested a review from visumickey April 17, 2023 13:01
mrober added 2 commits April 19, 2023 11:20
@mrober
Merge branch 'firebase-sessions' into sessions-dosample
39fbdff 
# Conflicts:
#	firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessions.kt
@mrober
Don't generate whole Session Start event for sampled event
80b3366
@mrober mrober merged commit 6cd629e into firebase-sessions Apr 20, 2023
@mrober mrober deleted the sessions-dosample branch April 20, 2023 19:32
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samedson samedson samedson approved these changes

@visumickey visumickey visumickey left review comments

Assignees
No one assigned
Labels
api: sessions no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrober @google-oss-bot @samedson @visumickey