Fix Apache license fetching. #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My fix in #484 changed the way the Apache license was handled, and all whitespace was stripped from this popular license. Essentially, the original code fetched it directly with the URL class while the other licenses were fetched with Jsoup. This commit restores this behavior. This has the unfortunate side-effect of re-introducing boilerplate code, but it's the most cost-effective solution for now.
|
/test new-smoke-tests |
vkryachko
approved these changes
Jun 11, 2019
|
@allisonbm92: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My fix in #484 changed the way the Apache license was handled, and all
whitespace was stripped from this popular license. Essentially, the
original code fetched it directly with the URL class while the other
licenses were fetched with Jsoup.
This commit restores this behavior. This has the unfortunate side-effect
of re-introducing boilerplate code, but it's the most cost-effective
solution for now.