Skip to content

Fix Apache license fetching. #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Fix Apache license fetching. #512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 28 additions & 13 deletions ...rc/src/main/groovy/com/google/firebase/gradle/plugins/license/RemoteLicenseFetcher.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import org.jsoup.nodes.Document

/**
* Parse licenses from remote urls*/
class RemoteLicenseFetcher implements Serializable {
abstract class RemoteLicenseFetcher implements Serializable {
private static final HtmlToPlainText TEXT_FORMATTER = new HtmlToPlainText()

private final String remoteUrl
Expand Down Expand Up @@ -51,7 +51,7 @@ class RemoteLicenseFetcher implements Serializable {
Thread.sleep(i * 1000)
}

return processDocument(Jsoup.connect(remoteUrl).get())
return getTextAttempt()
} catch (IOException ex) {
if (storedEx == null) {
storedEx = ex
Expand All @@ -64,10 +64,8 @@ class RemoteLicenseFetcher implements Serializable {
throw storedEx
}

/** Extracts the license text from the rest of the document. */
String processDocument(Document doc) {
return TEXT_FORMATTER.getPlainText(doc)
}
/** Attempts to download and extract the license exactly once. */
abstract String getTextAttempt()

static final class AndroidSdkTermsFetcher extends RemoteLicenseFetcher {

Expand All @@ -76,10 +74,11 @@ class RemoteLicenseFetcher implements Serializable {
}

@Override
String processDocument(Document doc) {
String getTextAttempt() {
// TODO(vkryachko, allisonbm92): Fix this silent failure.
// This evaluates to an empty string. The HTML for this page must have changed since this
// filter was original written. Interestingly, this is a hard-failure if run from Java.
def doc = Jsoup.connect(getRemoteUrl()).get()
return TEXT_FORMATTER.getPlainText(doc.select("#body-content > div.jd-descr > div")[0])
}
}
Expand All @@ -89,6 +88,11 @@ class RemoteLicenseFetcher implements Serializable {
Apache2LicenseFetcher() {
super("http://www.apache.org/licenses/LICENSE-2.0.txt")
}

@Override
String getTextAttempt() {
return getRemoteUrl().toURL().getText()
}
}

static final class AnotherApache2LicenseFetcher extends RemoteLicenseFetcher {
Expand All @@ -98,7 +102,8 @@ class RemoteLicenseFetcher implements Serializable {
}

@Override
String processDocument(Document doc) {
String getTextAttempt() {
def doc = Jsoup.connect(getRemoteUrl()).get()
return TEXT_FORMATTER.getPlainText(doc.select("#content-wrapper").get(0))
}
}
Expand All @@ -108,6 +113,11 @@ class RemoteLicenseFetcher implements Serializable {
YetAnotherApache2LicenseFetcher() {
super("http://www.apache.org/licenses/LICENSE-2.0")
}

@Override
String getTextAttempt() {
return getRemoteUrl().toURL().getText()
}
}

static final class BSDLicenseFetcher extends RemoteLicenseFetcher {
Expand All @@ -117,7 +127,8 @@ class RemoteLicenseFetcher implements Serializable {
}

@Override
String processDocument(Document doc) {
String getTextAttempt() {
def doc = Jsoup.connect(getRemoteUrl()).get()
return TEXT_FORMATTER.getPlainText(doc.select("#content-wrapper").get(0))
}
}
Expand All @@ -129,7 +140,8 @@ class RemoteLicenseFetcher implements Serializable {
}

@Override
String processDocument(Document doc) {
String getTextAttempt() {
def doc = Jsoup.connect(getRemoteUrl()).get()
return TEXT_FORMATTER.getPlainText(doc.select("#deed").get(0))
}
}
Expand All @@ -141,7 +153,8 @@ class RemoteLicenseFetcher implements Serializable {
}

@Override
String processDocument(Document doc) {
String getTextAttempt() {
def doc = Jsoup.connect(getRemoteUrl()).get()
return TEXT_FORMATTER.getPlainText(doc.select("#content-wrapper").get(0))
}
}
Expand All @@ -153,7 +166,8 @@ class RemoteLicenseFetcher implements Serializable {
}

@Override
String processDocument(Document doc) {
String getTextAttempt() {
def doc = Jsoup.connect(getRemoteUrl()).get()
return TEXT_FORMATTER.getPlainText(doc.select("#content-wrapper").get(0))
}
}
Expand All @@ -166,7 +180,8 @@ class RemoteLicenseFetcher implements Serializable {
}

@Override
String processDocument(Document doc) {
String getTextAttempt() {
def doc = Jsoup.connect(getRemoteUrl()).get()
return TEXT_FORMATTER.getPlainText(doc.select("body > table > tbody > tr:nth-child(2) > td:nth-child(2) > table > tbody > tr:nth-child(3) > td > en > blockquote").get(0))
}
}
Expand Down