Fix semver check #5241
Merged
Fix semver check #5241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
Please add a more descriptive title/description to know what was the error. |
Updated |
rlazo
approved these changes
Aug 15, 2023
Size Report 1Affected ProductsNo changes between base commit (da631d2) and merge commit (4485429).Test Logs |
Coverage Report 1Affected Products
Test Logs |
limsaehyun
pushed a commit
to limsaehyun/firebase-android-sdk
that referenced
this pull request
Sep 5, 2023
During the m134 release we were releasing firebase-sessions for the first time and due to which the semver test was broken. Hence the if conditions were added. These if conditions were not being evaluated correctly since it dependend on a malleable state of things. So now it's moved to checking in Gmaven itself if the project exists instead of depending on a malleable state which keeps being updated by the gradle tasks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the m134 release we were releasing firebase-sessions for the first time and due to which the semver test was broken. Hence the if conditions were added. These if conditions were not being evaluated correctly since it dependend on a malleable state of things. So now it's moved to checking in Gmaven itself if the project exists instead of depending on a malleable state which keeps being updated by the gradle tasks.