Skip to content

Fix semver check #5241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ class FirebaseLibraryPlugin : BaseFirebaseLibraryPlugin() {

private fun getSemverTaskAar(project: Project, firebaseLibrary: FirebaseLibraryExtension) {
project.mkdir("semver")
project.mkdir("semver/previous-version")
project.tasks.register<GmavenCopier>("copyPreviousArtifacts") {
dependsOn("bundleReleaseAar")
project.file("semver/previous.aar").delete()
Expand All @@ -111,7 +112,10 @@ class FirebaseLibraryPlugin : BaseFirebaseLibraryPlugin() {

project.tasks.register<Copy>("extractPreviousClasses") {
dependsOn("copyPreviousArtifacts")
if (project.file("semver/previous.aar").exists()) {
if (
GmavenHelper(firebaseLibrary.groupId.get(), firebaseLibrary.artifactId.get())
.isPresentInGmaven()
) {
from(project.zipTree("semver/previous.aar"))
into(project.file("semver/previous-version"))
}
Expand All @@ -121,15 +125,15 @@ class FirebaseLibraryPlugin : BaseFirebaseLibraryPlugin() {

val previousJarFile = project.file("semver/previous-version/classes.jar").absolutePath
project.tasks.register<ApiDiffer>("semverCheck") {
dependsOn("extractCurrentClasses")
dependsOn("extractPreviousClasses")
currentJar.value(currentJarFile)
previousJar.value(previousJarFile)
version.value(firebaseLibrary.version)
previousVersionString.value(
GmavenHelper(firebaseLibrary.groupId.get(), firebaseLibrary.artifactId.get())
.getLatestReleasedVersion()
)
dependsOn("extractCurrentClasses")
dependsOn("extractPreviousClasses")
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package com.google.firebase.gradle.plugins

import java.io.FileNotFoundException
import java.net.HttpURLConnection
import java.net.URL
import javax.xml.parsers.DocumentBuilder
import javax.xml.parsers.DocumentBuilderFactory
Expand All @@ -30,6 +31,16 @@ class GmavenHelper(val groupId: String, val artifactId: String) {
return "${GMAVEN_ROOT}/${groupIdAsPath}/${artifactId}/${version}/${pomFileName}"
}

fun isPresentInGmaven(): Boolean {
val groupIdAsPath = groupId.replace(".", "/")
val u = URL("${GMAVEN_ROOT}/${groupIdAsPath}/${artifactId}/maven-metadata.xml")
val huc: HttpURLConnection = u.openConnection() as HttpURLConnection
huc.setRequestMethod("GET") // OR huc.setRequestMethod ("HEAD");
huc.connect()
val code: Int = huc.getResponseCode()
return code == HttpURLConnection.HTTP_OK
}

fun getArtifactForVersion(version: String, isJar: Boolean): String {
val fileName =
if (isJar == true) "${artifactId}-${version}.jar" else "${artifactId}-${version}.aar"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,6 @@ abstract class PublishingPlugin : Plugin<Project> {
project.tasks.register(SEMVER_CHECK_TASK) {
for (releasingProject in releasingProjects) {
val semverCheckTask = releasingProject.tasks.named("semverCheck")

dependsOn(semverCheckTask)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,14 @@ abstract class GmavenCopier : DefaultTask() {
@TaskAction
fun run() {
val mavenHelper = GmavenHelper(groupId.get(), artifactId.get())
if (!mavenHelper.isPresentInGmaven()) {
return
}
val gMavenPath =
mavenHelper.getArtifactForVersion(
mavenHelper.getLatestReleasedVersion(),
!aarAndroidFile.get()
)
try {
URL(gMavenPath).openStream().use { Files.copy(it, Paths.get(filePath.get())) }
} catch (_: java.io.FileNotFoundException) {
// Gmaven Artifact doesn't exist.
return
}
URL(gMavenPath).openStream().use { Files.copy(it, Paths.get(filePath.get())) }
}
}