Skip to content

Update firebase-datatransport dependencies #5242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 15, 2023
Merged

Update firebase-datatransport dependencies #5242

merged 3 commits into from
Aug 15, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Aug 15, 2023

Bump common and transport-* to their latest released versions

@rlazo rlazo requested a review from VinayGuthal August 15, 2023 16:58
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-datatransport

    Overall coverage changed from ? (1ffc328) to 81.82% (85de56b) by ?.

    FilenameBase (1ffc328)Merge (85de56b)Diff
    LegacyTransportBackend.java?0.00%?
    TransportBackend.java?0.00%?
    TransportRegistrar.java?81.82%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aWh7zqRWJM.html

@github-actions
Copy link
Contributor

Unit Test Results

2 files   -    782  2 suites   - 782   19s ⏱️ - 35m 45s
1 tests  - 4 994  1 ✔️  - 4 970  0 💤  - 21  0 ❌  - 3 
2 runs   - 9 287  2 ✔️  - 9 242  0 💤  - 42  0 ❌  - 3 

Results for commit 56545e0. ± Comparison against base commit 1ffc328.

@rlazo rlazo enabled auto-merge (squash) August 15, 2023 17:11
@rlazo rlazo merged commit 34ccc9a into master Aug 15, 2023
@rlazo rlazo deleted the rl.m136.fixes branch August 15, 2023 17:15
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-datatransport

    TypeBase (1ffc328)Merge (85de56b)Diff
    apk (aggressive)162 kB163 kB+1.15 kB (+0.7%)
    apk (release)1.35 MB1.35 MB-1.20 kB (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qYwUJkDwiY.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (85de56b) and the base commit (1ffc328) are not available.

No macrobenchmark data found for the base commit (1ffc328). Analysis for the CI merge commit (85de56b) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ph6xPua9nT/index.html

limsaehyun pushed a commit to limsaehyun/firebase-android-sdk that referenced this pull request Sep 5, 2023
@rlazo @limsaehyun
Update firebase-datatransport dependencies (firebase#5242)
3fee0b8 
Bump common and transport-* to their latest released versions
@firebase firebase locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @VinayGuthal