Skip to content

Update project level deps from M136 #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2023
Merged

Update project level deps from M136 #5305

merged 3 commits into from
Sep 7, 2023

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Sep 7, 2023

Per b/299481147,

This updates some project level deps that should've been updated after M136, and will fix the error state occurring in M137.

@daymxn daymxn requested a review from rlazo September 7, 2023 17:49
@daymxn daymxn self-assigned this Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 7, 2023 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (b7a34fb) and merge commit (8246aaa).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xcnReOOzwP.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 7, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (b7a34fb)Merge (8246aaa)Diff
    apk (aggressive)433 kB433 kB+4 B (+0.0%)
    apk (release)2.17 MB2.17 MB+4 B (+0.0%)

  • firebase-inappmessaging

    TypeBase (b7a34fb)Merge (8246aaa)Diff
    apk (aggressive)701 kB701 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5RANgwCgg2.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023 •
edited
Loading

Unit Test Results

  56 files  +  32    56 suites  +32   2m 49s ⏱️ + 2m 33s
316 tests +201  315 ✔️ +200  1 💤 +1  0 ❌ ±0 
632 runs  +402  630 ✔️ +400  2 💤 +2  0 ❌ ±0 

Results for commit c25ebea. ± Comparison against base commit b7a34fb.

This pull request removes 115 and adds 316 tests. Note that renamed tests count towards both. 
com.google.firebase.components.ComponentDiscoveryTest ‑ discoverLazy_whenRegistrarClassDoesNotExist_shouldReturnProviderThatReturnsNull
com.google.firebase.components.ComponentDiscoveryTest ‑ discoverLazy_whenRegistrarClassesAreInvalid_shouldReturnThrowingProviders
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldCorrectlyInstantiateValidComponentRegistrars
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipClassesThatDontImplementComponentRegistrarInterface
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipClassesWithNoDefaultConstructors
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipNonExistentClasses
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipPrivateClasses
com.google.firebase.components.ComponentRuntimeTest ‑ container_shouldExposeAllProvidedInterfacesOfAComponent
com.google.firebase.components.ComponentRuntimeTest ‑ container_shouldExposeAllRegisteredSetValues
com.google.firebase.components.ComponentRuntimeTest ‑ container_withComponentProcessor_shouldDelegateToItForEachComponentRegistrar
…

com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addClickListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDismissListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDisplayErrorListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addImpressionListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addRemoveAllListeners_WorksAsExpected
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addRemoveListeners_WorksAsExpected
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_clearsInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_disablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionEnabling_enablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ clearDisplayListener_removesListener
…

♻️ This comment has been updated with latest results.

@daymxn daymxn merged commit 5a82746 into master Sep 7, 2023
@daymxn daymxn deleted the daymon-fix-project-level-deps branch September 7, 2023 19:38
@firebase firebase locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

@daymxn daymxn

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daymxn @google-oss-bot @rlazo