Crashlytics exception handler #6267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d6e112.
we are sending a task within a task for common worker which cause the async behavior, remove the re-submitting task for report finalization
Avoid `Task`s in `checkForPreviousCrash`. This is a step towards removing the nasty `awaitEvenIfOnMainThread`.
Deprecate `awaitEvenIfOnMain`. Next PR will be to drain the worker and remove this util.
Adjust time out and disk worker as discussed. This moves some things off the disk worker, but we plan to put them back after more refactoring.
Make init suspend on settings only, not on race. This allows us to avoid having a separate queue just for init and settings. If the app has unsent reports, but data collection and send unsent reports both have not been triggered, still let user actions queue up.
Add a precondition check for not main thread. This is more useful when we just want to enforce not main thread, not a specific thread.
Make doBackgroundInitializationAsync submit a callable instead of submit task Submit task results in a blocking behaviour when `SettingsTask` cannot be resolved during initialization Remove un-necessary task return
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-crashlytics### {{crashlytics}} version 19.1.1 {: #crashlytics_v19-1-1}
* {{fixed}} Improved data consistency for rapid user actions.
* {{changed}} Internal changes to improve startup time.
* {{changed}} Internal changes to the way background tasks are scheduled.
* {{changed}} Migrated SDK to use standard Firebase executors.
#### {{crashlytics}} Kotlin extensions version 19.1.1 {: #crashlytics-ktx_v19-1-1}
The Kotlin extensions library transitively includes the updated
`firebase-crashlytics` library. The Kotlin extensions library has no additional
updates. |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
Unit Test Results 8 files - 80 8 suites - 80 23s ⏱️ - 2m 16s Results for commit f357632. ± Comparison against base commit e6b4ace. This pull request removes 371 tests. |
mrober
approved these changes
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the old reversion #6191
merge back feature branch