Skip to content

Remove changes related to persistence issue #6191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Aug 19, 2024

Revert changes related to persistence issue. These changes are still on the crashlytics-exception-handler feature branch while we develop there. main is now in a good state for the next release, including the ODF and Session ID changes.

Copy link
Contributor

github-actions bot commented Aug 19, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-crashlytics

    Overall coverage changed from 11.58% (b83910b) to 11.22% (df05355) by -0.36%.

    FilenameBase (b83910b)Merge (df05355)Diff
    CrashlyticsBackgroundWorker.java?56.25%?
    CrashlyticsController.java18.42%16.10%-2.32%
    CrashlyticsLifecycleEvents.java?0.00%?
    CrashlyticsPreconditions.kt?0.00%?
    CrashlyticsWorker.java37.21%0.00%-37.21%
    DataCollectionArbiter.java84.27%83.33%-0.94%
    SessionReportingCoordinator.java41.71%42.11%+0.39%
    UserMetadata.java22.33%22.12%-0.21%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xY6R2aI05B.html

Copy link
Contributor

Unit Test Results

  8 files   -   16    8 suites   - 16   24s ⏱️ +7s
22 tests  -   93  22 ✔️  -   93  0 💤 ±0  0 ±0 
44 runs   - 186  44 ✔️  - 186  0 💤 ±0  0 ±0 

Results for commit da03580. ± Comparison against base commit b83910b.

This pull request removes 115 and adds 22 tests. Note that renamed tests count towards both.
com.google.firebase.components.ComponentDiscoveryTest ‑ discoverLazy_whenRegistrarClassDoesNotExist_shouldReturnProviderThatReturnsNull
com.google.firebase.components.ComponentDiscoveryTest ‑ discoverLazy_whenRegistrarClassesAreInvalid_shouldReturnThrowingProviders
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldCorrectlyInstantiateValidComponentRegistrars
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipClassesThatDontImplementComponentRegistrarInterface
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipClassesWithNoDefaultConstructors
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipNonExistentClasses
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipPrivateClasses
com.google.firebase.components.ComponentRuntimeTest ‑ container_shouldExposeAllProvidedInterfacesOfAComponent
com.google.firebase.components.ComponentRuntimeTest ‑ container_shouldExposeAllRegisteredSetValues
com.google.firebase.components.ComponentRuntimeTest ‑ container_withComponentProcessor_shouldDelegateToItForEachComponentRegistrar
…
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (b83910b)Merge (df05355)Diff
    aar410 kB419 kB+8.39 kB (+2.0%)
    apk (aggressive)698 kB695 kB-2.88 kB (-0.4%)
    apk (release)5.85 MB5.85 MB-644 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/So9xXeoBQI.html

@mrober mrober merged commit 4d6e112 into main Aug 19, 2024
46 checks passed
@mrober mrober deleted the crashlytics-persistence branch August 19, 2024 17:05
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentileb83910bdf05355DiffSignificant (?)
    p1010.4 ±2 ms9.68 ±2 ms-736 μs (-7.1%)NO
    p2511.0 ±2 ms10.2 ±2 ms-788 μs (-7.2%)NO
    p5011.9 ±2 ms11.0 ±2 ms-837 μs (-7.1%)NO
    p7512.9 ±2 ms12.1 ±2 ms-801 μs (-6.2%)NO
    p9014.1 ±2 ms13.3 ±2 ms-809 μs (-5.7%)NO

    20 test runs in comparison
    CommitTest Runs
    b83910b
    • 2024-08-15_15:55:13.133893_qilS
    • 2024-08-15_15:55:13.133953_kIIS
    • 2024-08-15_15:55:13.133963_XOBq
    • 2024-08-15_15:55:13.133973_xbZC
    • 2024-08-15_15:55:13.133982_THcw
    • 2024-08-15_15:55:13.133990_qkEm
    • 2024-08-15_15:55:13.133997_EIsz
    • 2024-08-15_15:55:13.134005_zHKh
    • 2024-08-15_15:55:13.134013_cxLo
    • 2024-08-15_15:55:13.134021_JwOL
    df05355
    • 2024-08-19_16:58:51.675333_paoX
    • 2024-08-19_16:58:51.675372_nqyS
    • 2024-08-19_16:58:51.675383_dERx
    • 2024-08-19_16:58:51.675393_uaxG
    • 2024-08-19_16:58:51.675402_ZsEf
    • 2024-08-19_16:58:51.675410_LDGk
    • 2024-08-19_16:58:51.675418_hOjc
    • 2024-08-19_16:58:51.675425_bKGr
    • 2024-08-19_16:58:51.675433_QZms
    • 2024-08-19_16:58:51.675445_ypOJ
    redfin-30
    Percentileb83910bdf05355DiffSignificant (?)
    p1012.9 ±4 ms17.1 ±6 ms+4.24 ms (+33.0%)NO
    p2513.6 ±5 ms18.2 ±7 ms+4.60 ms (+33.7%)NO
    p5014.4 ±6 ms19.9 ±8 ms+5.44 ms (+37.7%)NO
    p7515.5 ±7 ms21.6 ±9 ms+6.10 ms (+39.3%)NO
    p9017.3 ±8 ms24.0 ±9.6 ms+6.65 ms (+38.4%)NO

    20 test runs in comparison
    CommitTest Runs
    b83910b
    • 2024-08-15_15:55:13.133893_qilS
    • 2024-08-15_15:55:13.133953_kIIS
    • 2024-08-15_15:55:13.133963_XOBq
    • 2024-08-15_15:55:13.133973_xbZC
    • 2024-08-15_15:55:13.133982_THcw
    • 2024-08-15_15:55:13.133990_qkEm
    • 2024-08-15_15:55:13.133997_EIsz
    • 2024-08-15_15:55:13.134005_zHKh
    • 2024-08-15_15:55:13.134013_cxLo
    • 2024-08-15_15:55:13.134021_JwOL
    df05355
    • 2024-08-19_16:58:51.675333_paoX
    • 2024-08-19_16:58:51.675372_nqyS
    • 2024-08-19_16:58:51.675383_dERx
    • 2024-08-19_16:58:51.675393_uaxG
    • 2024-08-19_16:58:51.675402_ZsEf
    • 2024-08-19_16:58:51.675410_LDGk
    • 2024-08-19_16:58:51.675418_hOjc
    • 2024-08-19_16:58:51.675425_bKGr
    • 2024-08-19_16:58:51.675433_QZms
    • 2024-08-19_16:58:51.675445_ypOJ
  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentileb83910bdf05355DiffSignificant (?)
    p10136 ±112 μs225 ±403 μs+88.8 μs (+65.1%)NO
    p25145 ±118 μs237 ±418 μs+91.7 μs (+63.3%)NO
    p50163 ±128 μs261 ±438 μs+98.4 μs (+60.5%)NO
    p75200 ±164 μs310 ±482 μs+110 μs (+55.3%)NO
    p90272 ±208 μs419 ±543 μs+147 μs (+53.9%)NO

    20 test runs in comparison
    CommitTest Runs
    b83910b
    • 2024-08-15_15:55:13.133893_qilS
    • 2024-08-15_15:55:13.133953_kIIS
    • 2024-08-15_15:55:13.133963_XOBq
    • 2024-08-15_15:55:13.133973_xbZC
    • 2024-08-15_15:55:13.133982_THcw
    • 2024-08-15_15:55:13.133990_qkEm
    • 2024-08-15_15:55:13.133997_EIsz
    • 2024-08-15_15:55:13.134005_zHKh
    • 2024-08-15_15:55:13.134013_cxLo
    • 2024-08-15_15:55:13.134021_JwOL
    df05355
    • 2024-08-19_16:58:51.675333_paoX
    • 2024-08-19_16:58:51.675372_nqyS
    • 2024-08-19_16:58:51.675383_dERx
    • 2024-08-19_16:58:51.675393_uaxG
    • 2024-08-19_16:58:51.675402_ZsEf
    • 2024-08-19_16:58:51.675410_LDGk
    • 2024-08-19_16:58:51.675418_hOjc
    • 2024-08-19_16:58:51.675425_bKGr
    • 2024-08-19_16:58:51.675433_QZms
    • 2024-08-19_16:58:51.675445_ypOJ
    redfin-30
    Percentileb83910bdf05355DiffSignificant (?)
    p10341 ±340 μs199 ±47 μs-142 μs (-41.7%)NO
    p25395 ±436 μs225 ±75 μs-171 μs (-43.2%)NO
    p50465 ±527 μs277 ±124 μs-188 μs (-40.5%)NO
    p75604 ±714 μs384 ±256 μs-220 μs (-36.4%)NO
    p90776 ±976 μs526 ±372 μs-250 μs (-32.3%)NO

    20 test runs in comparison
    CommitTest Runs
    b83910b
    • 2024-08-15_15:55:13.133893_qilS
    • 2024-08-15_15:55:13.133953_kIIS
    • 2024-08-15_15:55:13.133963_XOBq
    • 2024-08-15_15:55:13.133973_xbZC
    • 2024-08-15_15:55:13.133982_THcw
    • 2024-08-15_15:55:13.133990_qkEm
    • 2024-08-15_15:55:13.133997_EIsz
    • 2024-08-15_15:55:13.134005_zHKh
    • 2024-08-15_15:55:13.134013_cxLo
    • 2024-08-15_15:55:13.134021_JwOL
    df05355
    • 2024-08-19_16:58:51.675333_paoX
    • 2024-08-19_16:58:51.675372_nqyS
    • 2024-08-19_16:58:51.675383_dERx
    • 2024-08-19_16:58:51.675393_uaxG
    • 2024-08-19_16:58:51.675402_ZsEf
    • 2024-08-19_16:58:51.675410_LDGk
    • 2024-08-19_16:58:51.675418_hOjc
    • 2024-08-19_16:58:51.675425_bKGr
    • 2024-08-19_16:58:51.675433_QZms
    • 2024-08-19_16:58:51.675445_ypOJ
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentileb83910bdf05355DiffSignificant (?)
    p102.54 ±0.4 ms2.96 ±0.6 ms+421 μs (+16.6%)NO
    p252.73 ±0.5 ms3.15 ±0.7 ms+421 μs (+15.5%)NO
    p503.04 ±0.6 ms3.50 ±0.7 ms+465 μs (+15.3%)NO
    p753.56 ±0.7 ms4.07 ±0.7 ms+511 μs (+14.4%)NO
    p904.32 ±0.8 ms4.79 ±0.8 ms+471 μs (+10.9%)NO

    20 test runs in comparison
    CommitTest Runs
    b83910b
    • 2024-08-15_15:55:13.133893_qilS
    • 2024-08-15_15:55:13.133953_kIIS
    • 2024-08-15_15:55:13.133963_XOBq
    • 2024-08-15_15:55:13.133973_xbZC
    • 2024-08-15_15:55:13.133982_THcw
    • 2024-08-15_15:55:13.133990_qkEm
    • 2024-08-15_15:55:13.133997_EIsz
    • 2024-08-15_15:55:13.134005_zHKh
    • 2024-08-15_15:55:13.134013_cxLo
    • 2024-08-15_15:55:13.134021_JwOL
    df05355
    • 2024-08-19_16:58:51.675333_paoX
    • 2024-08-19_16:58:51.675372_nqyS
    • 2024-08-19_16:58:51.675383_dERx
    • 2024-08-19_16:58:51.675393_uaxG
    • 2024-08-19_16:58:51.675402_ZsEf
    • 2024-08-19_16:58:51.675410_LDGk
    • 2024-08-19_16:58:51.675418_hOjc
    • 2024-08-19_16:58:51.675425_bKGr
    • 2024-08-19_16:58:51.675433_QZms
    • 2024-08-19_16:58:51.675445_ypOJ
    redfin-30
    Percentileb83910bdf05355DiffSignificant (?)
    p106.10 ±1 ms6.53 ±2 ms+428 μs (+7.0%)NO
    p256.50 ±1 ms7.12 ±2 ms+619 μs (+9.5%)NO
    p507.11 ±2 ms8.23 ±4 ms+1.12 ms (+15.7%)NO
    p758.04 ±3 ms9.67 ±6 ms+1.63 ms (+20.3%)NO
    p909.06 ±4 ms11.1 ±7 ms+2.03 ms (+22.4%)NO

    20 test runs in comparison
    CommitTest Runs
    b83910b
    • 2024-08-15_15:55:13.133893_qilS
    • 2024-08-15_15:55:13.133953_kIIS
    • 2024-08-15_15:55:13.133963_XOBq
    • 2024-08-15_15:55:13.133973_xbZC
    • 2024-08-15_15:55:13.133982_THcw
    • 2024-08-15_15:55:13.133990_qkEm
    • 2024-08-15_15:55:13.133997_EIsz
    • 2024-08-15_15:55:13.134005_zHKh
    • 2024-08-15_15:55:13.134013_cxLo
    • 2024-08-15_15:55:13.134021_JwOL
    df05355
    • 2024-08-19_16:58:51.675333_paoX
    • 2024-08-19_16:58:51.675372_nqyS
    • 2024-08-19_16:58:51.675383_dERx
    • 2024-08-19_16:58:51.675393_uaxG
    • 2024-08-19_16:58:51.675402_ZsEf
    • 2024-08-19_16:58:51.675410_LDGk
    • 2024-08-19_16:58:51.675418_hOjc
    • 2024-08-19_16:58:51.675425_bKGr
    • 2024-08-19_16:58:51.675433_QZms
    • 2024-08-19_16:58:51.675445_ypOJ
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileb83910bdf05355DiffSignificant (?)
    p10202 ±4 ms208 ±5 ms+5.43 ms (+2.7%)NO
    p25208 ±4 ms214 ±5 ms+5.85 ms (+2.8%)NO
    p50216 ±5 ms221 ±5 ms+5.31 ms (+2.5%)NO
    p75223 ±5 ms229 ±6 ms+6.46 ms (+2.9%)NO
    p90231 ±6 ms239 ±7 ms+7.48 ms (+3.2%)NO

    20 test runs in comparison
    CommitTest Runs
    b83910b
    • 2024-08-15_15:55:13.133893_qilS
    • 2024-08-15_15:55:13.133953_kIIS
    • 2024-08-15_15:55:13.133963_XOBq
    • 2024-08-15_15:55:13.133973_xbZC
    • 2024-08-15_15:55:13.133982_THcw
    • 2024-08-15_15:55:13.133990_qkEm
    • 2024-08-15_15:55:13.133997_EIsz
    • 2024-08-15_15:55:13.134005_zHKh
    • 2024-08-15_15:55:13.134013_cxLo
    • 2024-08-15_15:55:13.134021_JwOL
    df05355
    • 2024-08-19_16:58:51.675333_paoX
    • 2024-08-19_16:58:51.675372_nqyS
    • 2024-08-19_16:58:51.675383_dERx
    • 2024-08-19_16:58:51.675393_uaxG
    • 2024-08-19_16:58:51.675402_ZsEf
    • 2024-08-19_16:58:51.675410_LDGk
    • 2024-08-19_16:58:51.675418_hOjc
    • 2024-08-19_16:58:51.675425_bKGr
    • 2024-08-19_16:58:51.675433_QZms
    • 2024-08-19_16:58:51.675445_ypOJ
    redfin-30
    Percentileb83910bdf05355DiffSignificant (?)
    p10245 ±4 ms269 ±7 ms+24.0 ms (+9.8%)MAYBE
    p25250 ±5 ms275 ±7 ms+24.3 ms (+9.7%)MAYBE
    p50256 ±5 ms282 ±9 ms+26.1 ms (+10.2%)MAYBE
    p75263 ±6 ms292 ±10 ms+28.5 ms (+10.8%)MAYBE
    p90273 ±7 ms307 ±15 ms+34.7 ms (+12.7%)NO

    20 test runs in comparison
    CommitTest Runs
    b83910b
    • 2024-08-15_15:55:13.133893_qilS
    • 2024-08-15_15:55:13.133953_kIIS
    • 2024-08-15_15:55:13.133963_XOBq
    • 2024-08-15_15:55:13.133973_xbZC
    • 2024-08-15_15:55:13.133982_THcw
    • 2024-08-15_15:55:13.133990_qkEm
    • 2024-08-15_15:55:13.133997_EIsz
    • 2024-08-15_15:55:13.134005_zHKh
    • 2024-08-15_15:55:13.134013_cxLo
    • 2024-08-15_15:55:13.134021_JwOL
    df05355
    • 2024-08-19_16:58:51.675333_paoX
    • 2024-08-19_16:58:51.675372_nqyS
    • 2024-08-19_16:58:51.675383_dERx
    • 2024-08-19_16:58:51.675393_uaxG
    • 2024-08-19_16:58:51.675402_ZsEf
    • 2024-08-19_16:58:51.675410_LDGk
    • 2024-08-19_16:58:51.675418_hOjc
    • 2024-08-19_16:58:51.675425_bKGr
    • 2024-08-19_16:58:51.675433_QZms
    • 2024-08-19_16:58:51.675445_ypOJ

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JK4KKJoFJn/index.html

themiswang added a commit that referenced this pull request Sep 17, 2024
themiswang added a commit that referenced this pull request Sep 18, 2024
Revert the old reversion
#6191
merge back feature branch

---------

Co-authored-by: Matthew Robertson <[email protected]>
@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants