Modernize FirebaseLibraryExtension #6377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesNo release note changes were detected. If you made changes that should be |
Vertex AI Mock Responses Check
|
buildSrc Test Results37 tests 37 ✅ 1m 2s ⏱️ Results for commit ccb5a88. ♻️ This comment has been updated with latest results. |
rlazo
reviewed
Oct 17, 2024
buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
davidmotson
reviewed
Oct 17, 2024
buildSrc/src/test/kotlin/com/google/firebase/gradle/plugins/PublishingPluginTests.kt
Outdated
Show resolved
Hide resolved
...Src/src/main/java/com/google/firebase/gradle/plugins/ci/device/FirebaseTestLabExtension.java
Show resolved
Hide resolved
...dSrc/src/main/java/com/google/firebase/gradle/plugins/ci/ContinuousIntegrationExtension.java
Show resolved
Hide resolved
davidmotson
approved these changes
Oct 21, 2024
rlazo
reviewed
Oct 22, 2024
rlazo
reviewed
Oct 23, 2024
rlazo
approved these changes
Oct 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/270576405,
This migrates
FirebaseLibraryExtensionto Kotlin, and takes advantage of more modern gradle features (such as properties/conventions) to help with build time and maintenance.This also adds documentation for all the exposed properties and options on
FirebaseLibraryExtension.Future
TODOs have been left denoting possible future modernization efforts.This PR also fixes the following: