Only advance the limbo free snapshot if query is synced #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite what we talked about offline, I still think we need to only advance the last limbo free snapshot version if the query is CURRENT. This is because we only calculate Limbo documents when we are in sync in the server. While we don't persist resume tokens for queries that aren't CURRENT, we do persist the remaining query data (including the lastLimboFreeSnapshot). We should not do that unless we are CURRENT.
wilhuff
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite what we talked about offline, I still think we need to only advance the last limbo free snapshot version if the query is CURRENT. This is because we only calculate Limbo documents when we are in sync in the server. While we don't persist resume tokens for queries that aren't CURRENT, we do persist the remaining query data (including the lastLimboFreeSnapshot). We should not do that unless we are CURRENT.