Index-Free: Persist the lastLimboFreeSnapshot version #2152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/indexfree-synced
branch
from
100d85a to
6abfa65
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/indexfree-synced
branch
from
6abfa65 to
2db5d33
Compare
mikelehen
approved these changes
Sep 6, 2019
| true, | ||
| false | ||
| /* syncStateChanged= */ true, | ||
| /* excludesMetadataChanges= */ false |
| @@ -658,6 +658,8 @@ export class LocalStore { | |||
| return PersistencePromise.forEach( | |||
| viewChanges, | |||
| (viewChange: LocalViewChanges) => { | |||
| const targetId = viewChange.targetId; | |||
There was a problem hiding this comment.
nit: You could use this instead of viewChange.targetId in the next 2 statements as well...
| @@ -666,6 +668,21 @@ export class LocalStore { | |||
| viewChange.removedKeys, | |||
| viewChange.targetId | |||
| ); | |||
|
|
|||
| if (viewChange.fromCache) { | |||
There was a problem hiding this comment.
I think this should be !viewChange.fromCache?
There was a problem hiding this comment.
Yes. Tests for this are coming soon :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the end state of
firebase/firebase-android-sdk#771
firebase/firebase-android-sdk#767
firebase/firebase-android-sdk#699
firebase/firebase-android-sdk#616
Since there is a bunch of back and forth in these PRs, I based it on a combined diff: https://gist.github.com/schmidt-sebastian/d6c28b541d48442f19e50f9c78d78d6e