Skip to content

Remove newly redundant synced flag #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

synced is always !fromCache, so we don't need it.

@schmidt-sebastian
Copy link
Contributor Author

/test device-check-changed

@schmidt-sebastian
Copy link
Contributor Author

/retest

@schmidt-sebastian
Copy link
Contributor Author

/test check-changed

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Sep 5, 2019
@schmidt-sebastian schmidt-sebastian merged commit 934a88d into master Sep 5, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/synced branch September 5, 2019 22:44
schmidt-sebastian added a commit that referenced this pull request Sep 13, 2019
schmidt-sebastian added a commit that referenced this pull request Sep 13, 2019
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants