Skip to content

Add http redirect support to the cct transport backend. #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

Add http redirect support to the cct transport backend. #750

merged 1 commit into from
Aug 30, 2019

Conversation

vkryachko
Copy link
Member

Redirects are followed up to 4 times(after initial request).

@vkryachko
Add http redirect support to the cct transport backend.
3113117 
Redirects are followed up to 4 times(after initial request).
@vkryachko vkryachko requested a review from VinayGuthal August 29, 2019 19:20
@googlebot googlebot added the cla: yes Override cla label Aug 29, 2019
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.FirebaseFirestore.terminate() [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.waitForPendingWrites() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information 3113117 link /test api-information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VinayGuthal
Copy link
Contributor

Looks good!

@vkryachko vkryachko merged commit d824db8 into master Aug 30, 2019
@vkryachko vkryachko deleted the vk.transport_redirectRetries branch September 25, 2019 20:35
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @VinayGuthal @googlebot