-
Notifications
You must be signed in to change notification settings - Fork 625
Add http redirect support to the cct transport backend. #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...port-runtime/src/main/java/com/google/android/datatransport/runtime/retries/Function.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // Copyright 2019 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.android.datatransport.runtime.retries; | ||
|
|
||
| /** Generic functional interface which supports checked exceptions. */ | ||
| public interface Function<TInput, TResult, TException extends Throwable> { | ||
| TResult apply(TInput input) throws TException; | ||
| } |
62 changes: 62 additions & 0 deletions
62
...sport-runtime/src/main/java/com/google/android/datatransport/runtime/retries/Retries.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // Copyright 2019 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.android.datatransport.runtime.retries; | ||
|
|
||
| /** Provides utilities to retry function calls. */ | ||
| public final class Retries { | ||
| private Retries() {} | ||
|
|
||
| /** | ||
| * Retries given {@link Function} upto {@code maxAttempts} times. | ||
| * | ||
| * <p>It takes an {@code input} parameter that is passed to the first {@link Function} call. The | ||
| * rest of the retries are called with the value produced by the {@code retryStrategy}. If the | ||
| * {@code retryStrategy} returns null, the retries are stopped and the result of the last retry is | ||
| * returned. | ||
| * | ||
| * <p>Example | ||
| * | ||
| * <pre>{@code | ||
| * int initialParameter = 10; | ||
| * | ||
| * // finalResult is 12. | ||
| * int finalResult = retry(5, initialParameter, Integer::valueOf, (input, result) -> { | ||
| * if ( result.equals(12)) { | ||
| * return null; | ||
| * } | ||
| * return input + 1; | ||
| * }); | ||
| * }</pre> | ||
| */ | ||
| public static <TInput, TResult, TException extends Throwable> TResult retry( | ||
| int maxAttempts, | ||
| TInput input, | ||
| Function<TInput, TResult, TException> function, | ||
| RetryStrategy<TInput, TResult> retryStrategy) | ||
| throws TException { | ||
| if (maxAttempts < 1) { | ||
| return function.apply(input); | ||
| } | ||
|
|
||
| while (true) { | ||
| TResult result = function.apply(input); | ||
| input = retryStrategy.shouldRetry(input, result); | ||
|
|
||
| if (input == null || --maxAttempts < 1) { | ||
| return result; | ||
| } | ||
| } | ||
| } | ||
| } |
28 changes: 28 additions & 0 deletions
28
...runtime/src/main/java/com/google/android/datatransport/runtime/retries/RetryStrategy.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Copyright 2019 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.android.datatransport.runtime.retries; | ||
|
|
||
| import androidx.annotation.Nullable; | ||
|
|
||
| public interface RetryStrategy<TInput, TResult> { | ||
| /** | ||
| * Whether a function call should be retried with a new input. | ||
| * | ||
| * <p>Given an input and result of a function call, return a new input to cause call to be | ||
| * retried, returning null will prevent further retries. | ||
| */ | ||
| @Nullable | ||
| TInput shouldRetry(TInput input, TResult result); | ||
| } |
16 changes: 16 additions & 0 deletions
16
...-runtime/src/main/java/com/google/android/datatransport/runtime/retries/package-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Copyright 2019 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| /** @hide */ | ||
| package com.google.android.datatransport.runtime.retries; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.