Initial Admob 2021 pinned to 20.1.0 #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed some BannerViewHelper code, the rest requires upcoming listener revamp * added <string.h> include to banner_view_internal_android.cc
* removed nativeAdExpress and rewardedVideo iOS impls * removed extra comma in admob testapp project
jonsimantov
requested changes
Sep 8, 2021
| if (initialized_) { | ||
| CompleteFuture(kAdMobErrorAlreadyInitialized, "Ad is already initialized.", | ||
| callback_data->future_handle, callback_data->future_data); | ||
| return GetLastResult(kBannerViewFnInitialize); |
There was a problem hiding this comment.
Note that this pattern introduces a race condition that we should try to avoid in new code. See b/110082243 and cl/217546936 for details.
There was a problem hiding this comment.
I believe I fixed this. Please take a look.
a-maurice
reviewed
Sep 17, 2021
jonsimantov
approved these changes
Sep 20, 2021
| if(initialized_) { | ||
| future_data_.future_impl.Complete(callback_data->future_handle, | ||
| kAdMobErrorAlreadyInitialized, | ||
| "Ad is already initialized."); |
There was a problem hiding this comment.
nit: AdMob is already initialized
There was a problem hiding this comment.
In this case it's the ad that's already initialized, not admob.
a-maurice
approved these changes
Sep 20, 2021
jonsimantov
approved these changes
Sep 21, 2021
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @DellaBitta on commit e365f4f
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a baseline branch of Admob's 2021 development.
This change removes features that are no longer present in admob: RewardedAds, NativeExpressAds, etc. Additionally some work has been done to reduce the need for BannerViewHelper. Further work will be done here, and in the InterstiailAdHelper, when we rework the listener architecture.